Skip to content

Commit 23383e5

Browse files
authored
Fix outdated description for optimistic send (#1173)
* fix to remove the outdated description for optimistic send Signed-off-by: Jun Kimura <[email protected]> * fix to clarify channel state for sending packet Signed-off-by: Jun Kimura <[email protected]> * update history in ics-004 Signed-off-by: Jun Kimura <[email protected]> --------- Signed-off-by: Jun Kimura <[email protected]>
1 parent 3559362 commit 23383e5

File tree

1 file changed

+3
-3
lines changed
  • spec/core/ics-004-channel-and-packet-semantics

1 file changed

+3
-3
lines changed

spec/core/ics-004-channel-and-packet-semantics/README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -742,7 +742,7 @@ Calling modules MUST execute application logic atomically in conjunction with ca
742742

743743
The IBC handler performs the following steps in order:
744744

745-
- Checks that the channel is not closed to send packets
745+
- Checks that the channel is opened to send packets
746746
- Checks that the calling module owns the sending port (see [ICS 5](../ics-005-port-allocation))
747747
- Checks that the timeout height specified has not already passed on the destination chain
748748
- Increments the send sequence counter associated with the channel
@@ -1154,8 +1154,6 @@ In the case of an unordered channel, `timeoutPacket` checks the absence of the r
11541154

11551155
If relations are enforced between timeout heights of subsequent packets, safe bulk timeouts of all packets prior to a timed-out packet can be performed. This specification omits details for now.
11561156

1157-
Since we allow optimistic sending of packets (i.e. sending a packet before a channel opens), we must also allow optimistic timing out of packets. With optimistic sends, the packet may be sent on a channel that eventually opens or a channel that will never open. If the channel does open after the packet has timed out, then the packet will never be received on the counterparty so we can safely timeout optimistically. If the channel never opens, then we MUST timeout optimistically so that any state changes made during the optimistic send by the application can be safely reverted.
1158-
11591157
We pass the `relayer` address just as in [Receiving packets](#receiving-packets) to allow for possible incentivization here as well.
11601158

11611159
```typescript
@@ -1539,6 +1537,8 @@ Jan 10, 2022 - Add ORDERED_ALLOW_TIMEOUT channel type and appropriate logic
15391537

15401538
Mar 28, 2023 - Add `writeChannel` function to write channel end after executing application callback
15411539

1540+
Dec 4, 2024 - Remove the description for optimistic packet sending
1541+
15421542
## Copyright
15431543

15441544
All content herein is licensed under [Apache 2.0](https://www.apache.org/licenses/LICENSE-2.0).

0 commit comments

Comments
 (0)