Skip to content

Commit e6578fa

Browse files
jjjike2021gjermundgaraba
jjjike2021
and
gjermundgaraba
authored
chore(all): remove copy of the 'for' variable (#8195)
* fix * save * fix all --------- Co-authored-by: Gjermund Garaba <[email protected]>
1 parent e1eb033 commit e6578fa

File tree

127 files changed

+13
-561
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

127 files changed

+13
-561
lines changed

Diff for: ‎modules/apps/27-interchain-accounts/controller/ibc_middleware_test.go

-14
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,6 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenInit() {
171171

172172
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
173173
for _, tc := range testCases {
174-
tc := tc
175-
176174
suite.Run(tc.name, func() {
177175
suite.SetupTest() // reset
178176
isNilApp = false
@@ -326,8 +324,6 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenAck() {
326324

327325
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
328326
for _, tc := range testCases {
329-
tc := tc
330-
331327
suite.Run(tc.name, func() {
332328
suite.SetupTest() // reset
333329
isNilApp = false
@@ -455,8 +451,6 @@ func (suite *InterchainAccountsTestSuite) TestOnChanCloseConfirm() {
455451

456452
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
457453
for _, tc := range testCases {
458-
tc := tc
459-
460454
suite.Run(tc.name, func() {
461455
suite.SetupTest() // reset
462456
isNilApp = false
@@ -502,8 +496,6 @@ func (suite *InterchainAccountsTestSuite) TestOnRecvPacket() {
502496

503497
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
504498
for _, tc := range testCases {
505-
tc := tc
506-
507499
suite.Run(tc.name, func() {
508500
suite.SetupTest() // reset
509501

@@ -600,8 +592,6 @@ func (suite *InterchainAccountsTestSuite) TestOnAcknowledgementPacket() {
600592

601593
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
602594
for _, tc := range testCases {
603-
tc := tc
604-
605595
suite.Run(tc.msg, func() {
606596
suite.SetupTest() // reset
607597
isNilApp = false
@@ -694,8 +684,6 @@ func (suite *InterchainAccountsTestSuite) TestOnTimeoutPacket() {
694684

695685
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
696686
for _, tc := range testCases {
697-
tc := tc
698-
699687
suite.Run(tc.msg, func() {
700688
suite.SetupTest() // reset
701689
isNilApp = false
@@ -756,8 +744,6 @@ func (suite *InterchainAccountsTestSuite) TestSingleHostMultipleControllers() {
756744

757745
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
758746
for _, tc := range testCases {
759-
tc := tc
760-
761747
suite.Run(tc.msg, func() {
762748
// reset
763749
suite.SetupTest()

Diff for: ‎modules/apps/27-interchain-accounts/controller/keeper/account_test.go

-2
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ func (suite *KeeperTestSuite) TestRegisterInterchainAccount() {
5555
}
5656

5757
for _, tc := range testCases {
58-
tc := tc
59-
6058
suite.Run(tc.name, func() {
6159
suite.SetupTest()
6260

Diff for: ‎modules/apps/27-interchain-accounts/controller/keeper/genesis_test.go

-2
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ func (suite *KeeperTestSuite) TestInitGenesis() {
4747
Ports: ports,
4848
}
4949
for _, tc := range testCases {
50-
tc := tc
51-
5250
suite.Run(tc.name, func() {
5351
suite.SetupTest()
5452

Diff for: ‎modules/apps/27-interchain-accounts/controller/keeper/grpc_query_test.go

-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ func (suite *KeeperTestSuite) TestQueryInterchainAccount() {
4444

4545
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
4646
for _, tc := range testCases {
47-
tc := tc
48-
4947
suite.Run(tc.name, func() {
5048
suite.SetupTest()
5149

Diff for: ‎modules/apps/27-interchain-accounts/controller/keeper/handshake_test.go

-6
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,6 @@ func (suite *KeeperTestSuite) TestOnChanOpenInit() {
238238
}
239239

240240
for _, tc := range testCases {
241-
tc := tc
242-
243241
suite.Run(tc.name, func() {
244242
suite.SetupTest() // reset
245243

@@ -399,8 +397,6 @@ func (suite *KeeperTestSuite) TestOnChanOpenAck() {
399397

400398
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
401399
for _, tc := range testCases {
402-
tc := tc
403-
404400
suite.Run(tc.name, func() {
405401
suite.SetupTest() // reset
406402

@@ -463,8 +459,6 @@ func (suite *KeeperTestSuite) TestOnChanCloseConfirm() {
463459

464460
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
465461
for _, tc := range testCases {
466-
tc := tc
467-
468462
suite.Run(tc.name, func() {
469463
suite.SetupTest() // reset
470464

Diff for: ‎modules/apps/27-interchain-accounts/controller/keeper/keeper_test.go

+1-3
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ func (suite *KeeperTestSuite) TestNewKeeper() {
140140
}
141141

142142
for _, tc := range testCases {
143-
tc := tc
143+
144144
suite.SetupTest()
145145

146146
suite.Run(tc.name, func() {
@@ -317,8 +317,6 @@ func (suite *KeeperTestSuite) TestSetAndGetParams() {
317317
}
318318

319319
for _, tc := range testCases {
320-
tc := tc
321-
322320
suite.Run(tc.name, func() {
323321
suite.SetupTest() // reset
324322
ctx := suite.chainA.GetContext()

Diff for: ‎modules/apps/27-interchain-accounts/controller/keeper/migrations_test.go

-2
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ func (suite *KeeperTestSuite) TestMigratorMigrateParams() {
4242
}
4343

4444
for _, tc := range testCases {
45-
tc := tc
46-
4745
suite.Run(fmt.Sprintf("case %s", tc.msg), func() {
4846
suite.SetupTest() // reset
4947

Diff for: ‎modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go

-6
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ func (suite *KeeperTestSuite) TestRegisterInterchainAccount_MsgServer() {
6767

6868
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
6969
for _, tc := range testCases {
70-
tc := tc
71-
7270
suite.Run(tc.name, func() {
7371
expectedOrderding = ordering
7472

@@ -147,8 +145,6 @@ func (suite *KeeperTestSuite) TestSubmitTx() {
147145

148146
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
149147
for _, tc := range testCases {
150-
tc := tc
151-
152148
suite.Run(tc.name, func() {
153149
suite.SetupTest()
154150

@@ -241,8 +237,6 @@ func (suite *KeeperTestSuite) TestUpdateParams() {
241237
}
242238

243239
for _, tc := range testCases {
244-
tc := tc
245-
246240
suite.Run(tc.name, func() {
247241
suite.SetupTest()
248242
_, err := suite.chainA.GetSimApp().ICAControllerKeeper.UpdateParams(suite.chainA.GetContext(), tc.msg)

Diff for: ‎modules/apps/27-interchain-accounts/controller/keeper/relay_test.go

-4
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,6 @@ func (suite *KeeperTestSuite) TestSendTx() {
142142

143143
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
144144
for _, tc := range testCases {
145-
tc := tc
146-
147145
suite.Run(tc.msg, func() {
148146
suite.SetupTest() // reset
149147
timeoutTimestamp = ^uint64(0) // default
@@ -186,8 +184,6 @@ func (suite *KeeperTestSuite) TestOnTimeoutPacket() {
186184

187185
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
188186
for _, tc := range testCases {
189-
tc := tc
190-
191187
suite.Run(tc.msg, func() {
192188
suite.SetupTest() // reset
193189

Diff for: ‎modules/apps/27-interchain-accounts/controller/types/codec_test.go

-2
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ func TestCodecTypeRegistration(t *testing.T) {
4343
}
4444

4545
for _, tc := range testCases {
46-
tc := tc
47-
4846
t.Run(tc.name, func(t *testing.T) {
4947
encodingCfg := moduletestutil.MakeTestEncodingConfig(ica.AppModuleBasic{})
5048
msg, err := encodingCfg.Codec.InterfaceRegistry().Resolve(tc.typeURL)

Diff for: ‎modules/apps/27-interchain-accounts/controller/types/msgs_test.go

-7
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ func TestMsgRegisterInterchainAccountValidateBasic(t *testing.T) {
7171
}
7272

7373
for i, tc := range testCases {
74-
i, tc := i, tc
75-
7674
msg = types.NewMsgRegisterInterchainAccount(
7775
ibctesting.FirstConnectionID,
7876
ibctesting.TestAccAddress,
@@ -153,8 +151,6 @@ func TestMsgSendTxValidateBasic(t *testing.T) {
153151
}
154152

155153
for i, tc := range testCases {
156-
i, tc := i, tc
157-
158154
msgBankSend := &banktypes.MsgSend{
159155
FromAddress: ibctesting.TestAccAddress,
160156
ToAddress: ibctesting.TestAccAddress,
@@ -233,8 +229,6 @@ func TestMsgUpdateParamsValidateBasic(t *testing.T) {
233229
}
234230

235231
for i, tc := range testCases {
236-
i, tc := i, tc
237-
238232
err := tc.msg.ValidateBasic()
239233
if tc.expErr == nil {
240234
require.NoError(t, err, "valid test case %d failed: %s", i, tc.name)
@@ -256,7 +250,6 @@ func TestMsgUpdateParamsGetSigners(t *testing.T) {
256250
}
257251

258252
for _, tc := range testCases {
259-
tc := tc
260253

261254
msg := types.MsgUpdateParams{
262255
Signer: tc.address.String(),

Diff for: ‎modules/apps/27-interchain-accounts/genesis/types/genesis_test.go

-6
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ func (suite *GenesisTypesTestSuite) TestValidateGenesisState() {
6666
}
6767

6868
for _, tc := range testCases {
69-
tc := tc
70-
7169
suite.Run(tc.name, func() {
7270
genesisState = *genesistypes.DefaultGenesis()
7371

@@ -192,8 +190,6 @@ func (suite *GenesisTypesTestSuite) TestValidateControllerGenesisState() {
192190
}
193191

194192
for _, tc := range testCases {
195-
tc := tc
196-
197193
suite.Run(tc.name, func() {
198194
genesisState = genesistypes.DefaultControllerGenesis()
199195

@@ -318,8 +314,6 @@ func (suite *GenesisTypesTestSuite) TestValidateHostGenesisState() {
318314
}
319315

320316
for _, tc := range testCases {
321-
tc := tc
322-
323317
suite.Run(tc.name, func() {
324318
genesisState = genesistypes.DefaultHostGenesis()
325319

Diff for: ‎modules/apps/27-interchain-accounts/host/client/cli/tx_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ func TestGeneratePacketData(t *testing.T) {
104104
encodings := []string{icatypes.EncodingProtobuf, icatypes.EncodingProto3JSON}
105105
for _, encoding := range encodings {
106106
for _, tc := range tests {
107-
tc := tc
107+
108108
ir := codectypes.NewInterfaceRegistry()
109109
if tc.registerInterfaceFn != nil {
110110
tc.registerInterfaceFn(ir)

Diff for: ‎modules/apps/27-interchain-accounts/host/ibc_module_test.go

-12
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,6 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenTry() {
174174

175175
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
176176
for _, tc := range testCases {
177-
tc := tc
178-
179177
suite.Run(tc.name, func() {
180178
suite.SetupTest() // reset
181179

@@ -288,8 +286,6 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenConfirm() {
288286

289287
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
290288
for _, tc := range testCases {
291-
tc := tc
292-
293289
suite.Run(tc.name, func() {
294290
suite.SetupTest()
295291
path := NewICAPath(suite.chainA, suite.chainB, ordering)
@@ -358,8 +354,6 @@ func (suite *InterchainAccountsTestSuite) TestOnChanCloseConfirm() {
358354

359355
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
360356
for _, tc := range testCases {
361-
tc := tc
362-
363357
suite.Run(tc.name, func() {
364358
suite.SetupTest() // reset
365359

@@ -424,8 +418,6 @@ func (suite *InterchainAccountsTestSuite) TestOnRecvPacket() {
424418

425419
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
426420
for _, tc := range testCases {
427-
tc := tc
428-
429421
suite.Run(tc.name, func() {
430422
suite.SetupTest() // reset
431423

@@ -537,8 +529,6 @@ func (suite *InterchainAccountsTestSuite) TestOnAcknowledgementPacket() {
537529

538530
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
539531
for _, tc := range testCases {
540-
tc := tc
541-
542532
suite.Run(tc.name, func() {
543533
suite.SetupTest() // reset
544534

@@ -589,8 +579,6 @@ func (suite *InterchainAccountsTestSuite) TestOnTimeoutPacket() {
589579

590580
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
591581
for _, tc := range testCases {
592-
tc := tc
593-
594582
suite.Run(tc.name, func() {
595583
suite.SetupTest() // reset
596584

Diff for: ‎modules/apps/27-interchain-accounts/host/keeper/genesis_test.go

-2
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ func (suite *KeeperTestSuite) TestGenesisParams() {
6161
}
6262

6363
for _, tc := range testCases {
64-
tc := tc
65-
6664
suite.Run(tc.name, func() {
6765
suite.SetupTest() // reset
6866
interchainAccAddr := icatypes.GenerateAddress(suite.chainB.GetContext(), ibctesting.FirstConnectionID, TestPortID)

Diff for: ‎modules/apps/27-interchain-accounts/host/keeper/handshake_test.go

-4
Original file line numberDiff line numberDiff line change
@@ -251,8 +251,6 @@ func (suite *KeeperTestSuite) TestOnChanOpenTry() {
251251
}
252252

253253
for _, tc := range testCases {
254-
tc := tc
255-
256254
suite.Run(tc.name, func() {
257255
suite.SetupTest() // reset
258256

@@ -338,8 +336,6 @@ func (suite *KeeperTestSuite) TestOnChanOpenConfirm() {
338336

339337
for _, ordering := range []channeltypes.Order{channeltypes.UNORDERED, channeltypes.ORDERED} {
340338
for _, tc := range testCases {
341-
tc := tc
342-
343339
suite.Run(tc.name, func() {
344340
suite.SetupTest() // reset
345341

Diff for: ‎modules/apps/27-interchain-accounts/host/keeper/keeper_test.go

+1-3
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ func (suite *KeeperTestSuite) TestNewKeeper() {
180180
}
181181

182182
for _, tc := range testCases {
183-
tc := tc
183+
184184
suite.SetupTest()
185185

186186
suite.Run(tc.name, func() {
@@ -376,8 +376,6 @@ func (suite *KeeperTestSuite) TestParams() {
376376
}
377377

378378
for _, tc := range testCases {
379-
tc := tc
380-
381379
suite.Run(tc.name, func() {
382380
suite.SetupTest() // reset
383381
ctx := suite.chainA.GetContext()

Diff for: ‎modules/apps/27-interchain-accounts/host/keeper/migrations_test.go

-2
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ func (suite *KeeperTestSuite) TestMigratorMigrateParams() {
4646
}
4747

4848
for _, tc := range testCases {
49-
tc := tc
50-
5149
suite.Run(fmt.Sprintf("case %s", tc.msg), func() {
5250
suite.SetupTest() // reset
5351

Diff for: ‎modules/apps/27-interchain-accounts/host/keeper/msg_server_test.go

-4
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,6 @@ func (suite *KeeperTestSuite) TestModuleQuerySafe() {
124124
}
125125

126126
for _, tc := range testCases {
127-
tc := tc
128-
129127
suite.Run(tc.name, func() {
130128
suite.SetupTest()
131129

@@ -171,8 +169,6 @@ func (suite *KeeperTestSuite) TestUpdateParams() {
171169
}
172170

173171
for _, tc := range testCases {
174-
tc := tc
175-
176172
suite.Run(tc.name, func() {
177173
suite.SetupTest()
178174

0 commit comments

Comments
 (0)