fix(x/staking): avoid overriding error #23076
Conversation
tac0turtle
requested review from
facundomedica,
testinginprod,
JulianToledano,
ziscky and
a team
as code owners
📝 WalkthroughWalkthroughThe pull request introduces a minor modification in the Changes
Suggested labels
Suggested reviewers
Possibly related PRs
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
@tac0turtle your pull request is missing a changelog! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
x/staking/keeper/delegation.go(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
x/staking/keeper/delegation.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
| unbondingTime, err2 := k.UnbondingTime(ctx) | ||
| if err2 != nil { |
There was a problem hiding this comment.
Correct the returned error variable to match the renamed one.
Currently, the code captures the error in err2 but returns the outer err, which could be uninitialized or stale. To ensure we return the right error, align the return statement with the newly introduced variable:
- unbondingTime, err2 := k.UnbondingTime(ctx)
- if err2 != nil {
- return completionTime, height, false, err
- }
+ unbondingTime, err := k.UnbondingTime(ctx)
+ if err != nil {
+ return completionTime, height, false, err
+ }Committable suggestion skipped: line range outside the PR's diff.
julienrbrt
changed the title
| unbondingTime, err := k.UnbondingTime(ctx) | ||
| if err != nil { | ||
| unbondingTime, err2 := k.UnbondingTime(ctx) | ||
| if err2 != nil { | ||
| return completionTime, height, false, err |
There was a problem hiding this comment.
| return completionTime, height, false, err | |
| return completionTime, height, false, errors.Join(err, err2) |
We should error join the two errors, otherwise we miss the second one now.
Description
This pr fixes an error overwrite that was happening.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Bug Fixes
Style