Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bytes feature flag for proto? #519

Open
gluax opened this issue Mar 2, 2025 · 1 comment
Open

bytes feature flag for proto? #519

gluax opened this issue Mar 2, 2025 · 1 comment

Comments

@gluax
Copy link

gluax commented Mar 2, 2025

Hi hi, was wondering if the functionality could be added to support using the Bytes type in place of Vec<u8>. There's an option for this using neoeinstein-prost.

Might have to add some logic to the build.rs to support it being a cfg though.

@tony-iqlusion
Copy link
Member

tony-iqlusion commented Mar 3, 2025

We check in the generated Rust code (because, among other reasons, the generated code contains ambiguous type names due to the source protos which needs modification to even compile), so this would need to be a change that is made to the public API.

If we do it, it would probably only make sense to do it consistently across all of the crates in the ecosystem which use generated protos, including tendermint-proto and ibc-proto.

So the right place to start is probably with tendermint-proto: https://github.com/tendermint/tendermint/blob/main/proto/README.md

@cosmos cosmos deleted a comment from tarcieri Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants