Copy throws exception on UnityEngine.Object. Added copy method for unity object overwrite.

Author: coryleach

Runtime/SaveLoadManager.cs

@@ -82,6 +82,10 @@ public void Save(object obj, string filename, string folder = null)
         /// <returns>duplicated instance</returns>
         public object Copy(object obj)
         {
+            if (obj is UnityEngine.Object)
+            {
+                throw new ArgumentException("UnityEngine.Object and child types not supported by copy method.");
+            }
             var saveLoadMethod = GetSaveLoadMethod(saveMethod);
             return saveLoadMethod.Copy(obj);
         }
@@ -95,6 +99,10 @@ public object Copy(object obj)
         /// <returns>duplicated instance</returns>
         public T Copy<T>(T obj)
         {
+            if (obj is UnityEngine.Object)
+            {
+                throw new ArgumentException("UnityEngine.Object and child types not supported by copy method.");
+            }
             var saveLoadMethod = GetSaveLoadMethod(saveMethod);
             return (T)saveLoadMethod.Copy(obj);
         }
@@ -221,6 +229,17 @@ public bool LoadUnityObjectOverwrite(UnityEngine.Object objectToOverwrite, strin
             JsonUtility.FromJsonOverwrite(savedObj.jsonData,objectToOverwrite);
             return true;
         }
+
+        /// <summary>
+        /// Copies the serializable fields from one UnityEngine.Object to another
+        /// </summary>
+        /// <param name="toCopy">object which should be copied</param>
+        /// <param name="toOverwrite">object onto which copied fields should be written</param>
+        public void CopyUnityObjectOverwrite(UnityEngine.Object toCopy, UnityEngine.Object toOverwrite)
+        {
+            var jsonData = JsonUtility.ToJson(toCopy);
+            JsonUtility.FromJsonOverwrite(jsonData,toOverwrite);
+        }
 
         /// <summary>
         /// JsonSerializedUnityObject

Tests/Runtime/SaveLoadManagerTests.cs

@@ -17,6 +17,7 @@ public class SaveLoadTestObject
             public int count;
         }
 
+        [Serializable]
         public class SaveLoadTestUnityObject : ScriptableObject
         {
             public string textValue = "";
@@ -207,16 +208,33 @@ public void CanCopyUnityObject([Values] SerializationMethodType method)
         {
             var manager = CreateManager(method);
             var testObj = ScriptableObject.CreateInstance<SaveLoadTestUnityObject>();
-            testObj.textValue = "MyValue";
+            var loadedTestObj = ScriptableObject.CreateInstance<SaveLoadTestUnityObject>();
 
-            var loadedTestObj = manager.Copy(testObj);
+            testObj.textValue = "MyValue";
 
+            manager.CopyUnityObjectOverwrite(testObj,loadedTestObj);
+
             Assert.IsTrue(loadedTestObj.textValue == testObj.textValue);
 
             Object.Destroy(testObj);
             Object.Destroy(loadedTestObj);
             Object.Destroy(manager);
         }
+        
+        [Test]
+        public void CopyThrowsArgumentExceptionOnUnityObject([Values] SerializationMethodType method)
+        {
+            var manager = CreateManager(method);
+            var testObj = ScriptableObject.CreateInstance<SaveLoadTestUnityObject>();
+
+            Assert.Throws<ArgumentException>(() =>
+            {
+                manager.Copy(testObj);
+            });
+            
+            Object.Destroy(testObj);
+            Object.Destroy(manager);
+        }
 
         [Test]
         public void CanSaveAndLoadDictionary([Values(