-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FontAwesome V6 #888
Comments
Hi! So I have a question about this one, since I'm planning to get to it sometime within September while also tackling the Bootstrap v5 update. I've done this already for a handful of sites and while v6 does offer backward compatibility - so pre-existing icons like So then my question is: would it be reasonable to add a site setting for this? I'm thinking of allowing the option of staying with v5 icons completely, switching to v6 icons completely, and maybe an option to allow icons with v5 classes ( Let me know if that sounds like a good option to have, and I'll go ahead and make a note of it for when I do the update! |
I think that'd be a good option, if you're willing to sort it out! A config setting seems to me to make the most sense, and that's fairly easy to implement anyhow. |
- Adds a site setting that allows site owners to choose from v5, v6, and mixed versions of FontAwesome files - Uses a helper function to grab the setting and generate the asset url for app.blade.php
Thanks @liwoyadan - I'm leaving this issue open until it auto-closes eventually, but with your last contribution, this issue is officially resolved. :) |
While we're on the subject of upgrading- FontAwesome also comes to mind. V6 has been out for quite a while..
But we're still on V5 nonetheless.
I found this document on migrating to v5: (https://docs.fontawesome.com/web/setup/upgrade).
Fortunately, it seems that upgrading THAT is less of a hassle, as they heavily support backwards compatibility.
The text was updated successfully, but these errors were encountered: