Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesome V6 #888

Open
SpeedyD opened this issue Mar 26, 2024 · 3 comments · Fixed by #1100
Open

FontAwesome V6 #888

SpeedyD opened this issue Mar 26, 2024 · 3 comments · Fixed by #1100
Labels
dependencies Pull requests that update a dependency file

Comments

@SpeedyD
Copy link
Contributor

SpeedyD commented Mar 26, 2024

While we're on the subject of upgrading- FontAwesome also comes to mind. V6 has been out for quite a while..

But we're still on V5 nonetheless.

I found this document on migrating to v5: (https://docs.fontawesome.com/web/setup/upgrade).

Fortunately, it seems that upgrading THAT is less of a hassle, as they heavily support backwards compatibility.

@itinerare itinerare added the dependencies Pull requests that update a dependency file label Mar 26, 2024
@liwoyadan
Copy link

Hi! So I have a question about this one, since I'm planning to get to it sometime within September while also tackling the Bootstrap v5 update.

I've done this already for a handful of sites and while v6 does offer backward compatibility - so pre-existing icons like fas fa-crown (for the admin panel link) don't need to be changed to the new v6 icon classes - they will specifically show the v6 version of the icon despite using the v5 classes. With that in mind, I recall seeing people mention in the Discord once or twice that they prefer the v5 icon style compared to the v6 icon style - for example: the crown icon in v5 has a base on the bottom and is a little more angular, whereas the crown icon in v6 is lacking the base and is more rounded.

So then my question is: would it be reasonable to add a site setting for this? I'm thinking of allowing the option of staying with v5 icons completely, switching to v6 icons completely, and maybe an option to allow icons with v5 classes (fas fa-crown) to remain with their v5 look while icons with v6 classes (fa-solid fa-crown) will look like the v6 versions. This won't be too difficult - I can easily compile a minimized stylesheet for this with SCSS.

Let me know if that sounds like a good option to have, and I'll go ahead and make a note of it for when I do the update!

@itinerare
Copy link
Collaborator

I think that'd be a good option, if you're willing to sort it out! A config setting seems to me to make the most sense, and that's fairly easy to implement anyhow.

liwoyadan added a commit to liwoyadan/lorekeeper that referenced this issue Oct 29, 2024
- Adds a site setting that allows site owners to choose from v5, v6, and mixed versions of FontAwesome files
- Uses a helper function to grab the setting and generate the asset url for app.blade.php
@SpeedyD
Copy link
Contributor Author

SpeedyD commented Oct 29, 2024

Thanks @liwoyadan - I'm leaving this issue open until it auto-closes eventually, but with your last contribution, this issue is officially resolved. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants