Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch feature/traits pages to proper pages (similar to Items) #1223

Open
MarskyMessier opened this issue Feb 4, 2025 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@MarskyMessier
Copy link

While fiddling around Trait expanded I realized that features don't have their own page load like items got recently, this is just a proposition to bring features to the same level and having their url be their ID number instead of the name mishmash LK has right now (which was the case for items as well previously to Shop Feature update).

@itinerare itinerare added the enhancement New feature or request label Feb 4, 2025
@SpeedyD
Copy link
Contributor

SpeedyD commented Feb 4, 2025

..I recall there being a very specific reason why this wasn't done, but I do not recall the reason itself. 🤔

@MarskyMessier
Copy link
Author

Would love to know the reason, given I don't see any major setback with that change aside maybe throwing off a few extension with files around? But from personal experience it's been fine so far to have trait have their own page like items and their url be their ID number.

@preimpression
Copy link
Contributor

I see no reason to keep traits with the name url method. If it's a worry about IDs being public, they're already in the URL when searching for characters with specific traits.

@SpeedyD
Copy link
Contributor

SpeedyD commented Feb 21, 2025

I wish I had a better memory, sorry everyone.. ;u;/

But frankly, if nobody seems to have an issue with this, then I don't see why not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants