Repository navigation
Commit ef3be87
fix: pin esbuild across the whole tree, so npm 10 installs the lockfile too
`overrides.tsup.esbuild` pinned esbuild for tsup alone, and npm 10 and npm 11
then built different trees from the same manifest:
- npm 11 collapsed the tree onto esbuild 0.19.7.
- npm 10 kept vite's own esbuild 0.28.2 beside it, so the lockfile that npm 11
wrote looked incomplete and `npm ci` stopped with
"Missing: esbuild@0.28.2 from lock file", for esbuild and its 25
per-platform packages.
One lockfile could not serve both resolvers, so the test workflow installed
npm 11 on each leg. A contributor on node 20 or node 22 still met the failure
locally, because those versions ship npm 10.
`overrides.esbuild` pins the whole tree instead, and one lockfile then serves
both. The workflow no longer installs npm 11, and the stock npm of each node
version installs this lockfile:
| node | npm | `npm ci` |
| --- | --- | --- |
| 20 | 10.8.2 | passes |
| 22 | 10.9.8 | passes |
| 24 | 11.19.0 | passes |
The bundle does not change: release/cjs/lossless.cjs and
release/cjs/lossless.cjs.map stay byte-identical to the files that
cornerstonejs/codecs vendors, and the lint and all 54 tests pass on each node
version and on windows.
`npm audit` moves from 1 moderate to 4 moderate, and stays at 0 high and 0
critical. All four are the one esbuild development-server advisory, which now
reaches more paths because the pin covers the whole tree. This repository never
starts that server.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent ecf3053 commit ef3be87
4 files changed
Lines changed: 132 additions & 194 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | 20 | | |
30 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
31 | 24 | | |
32 | 25 | | |
33 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
64 | 70 | | |
65 | 71 | | |
66 | 72 | | |
| |||
0 commit comments