fix(CDropdown): menu not closing on button click

mrholek · mrholek · commit 58ba804c02b8 · 2025-10-07T18:53:42.000+02:00
diff --git a/packages/coreui-react/src/components/dropdown/CDropdown.tsx b/packages/coreui-react/src/components/dropdown/CDropdown.tsx
@@ -368,7 +368,7 @@ export const CDropdown: PolymorphicRefForwardingComponent<'div', CDropdownProps>
         }
 
         const target = event.target as HTMLElement | null
-        const FORM_TAG_RE = /^(input|select|option|textarea|form|button|label)$/i
+        const FORM_TAG_RE = /^(input|select|option|textarea|form)$/i
 
         if (isOnMenu && target && FORM_TAG_RE.test(target.tagName)) {
           return

Original file line number	Diff line number	Diff line change
`@@ -368,7 +368,7 @@ export const CDropdown: PolymorphicRefForwardingComponent<'div', CDropdownProps>`
`368`	`368`	`}`
`369`	`369`
`370`	`370`	`const target = event.target as HTMLElement \| null`
`371`		`- const FORM_TAG_RE = /^(input\|select\|option\|textarea\|form\|button\|label)$/i`
	`371`	`+ const FORM_TAG_RE = /^(input\|select\|option\|textarea\|form)$/i`
`372`	`372`
`373`	`373`	`if (isOnMenu && target && FORM_TAG_RE.test(target.tagName)) {`
`374`	`374`	`return`