|
| 1 | +# Contributing to CoreUI |
| 2 | + |
| 3 | +Looking to contribute something to CoreUI? **Here's how you can help.** |
| 4 | + |
| 5 | +Please take a moment to review this document in order to make the contribution process easy and effective for everyone involved. |
| 6 | + |
| 7 | +Following these guidelines helps to communicate that you respect the time of the developers managing and developing this open source project. In return, they should reciprocate that respect in addressing your issue or assessing |
| 8 | +patches and features. |
| 9 | + |
| 10 | +## Using the issue tracker |
| 11 | + |
| 12 | +The [issue tracker](https://github.com/coreui/coreui-angular/issues) is |
| 13 | +the preferred channel for [bug reports](#bug-reports), [features requests](#feature-requests) |
| 14 | +and [submitting pull requests](#pull-requests), but please respect the following |
| 15 | +restrictions: |
| 16 | + |
| 17 | +* Please **do not** use the issue tracker for personal support requests. |
| 18 | + |
| 19 | +* Please **do not** post comments consisting solely of "+1" or ":thumbsup:". |
| 20 | + Use [GitHub's "reactions" feature](https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments) |
| 21 | + instead. |
| 22 | + |
| 23 | +## Bug reports |
| 24 | + |
| 25 | +A bug is a _demonstrable problem_ that is caused by the code in the repository. |
| 26 | +Good bug reports are extremely helpful, so thanks! |
| 27 | + |
| 28 | +Guidelines for bug reports: |
| 29 | + |
| 30 | +0. **Validate and lint your code** — to ensure your problem isn't caused by a simple error in your own code. |
| 31 | + |
| 32 | +1. **Use the GitHub issue search** — check if the issue has already been reported. |
| 33 | + |
| 34 | +2. **Check if the issue has been fixed** — try to reproduce it using the latest `master` or development branch in the repository. |
| 35 | + |
| 36 | +3. **Isolate the problem** — ideally create a [reduced test case](https://css-tricks.com/reduced-test-cases/) and a live example. [This JS Bin](http://jsbin.com/lefey/1/edit?html,output) is a helpful template. |
| 37 | + |
| 38 | + |
| 39 | +A good bug report shouldn't leave others needing to chase you up for more |
| 40 | +information. Please try to be as detailed as possible in your report. What is |
| 41 | +your environment? What steps will reproduce the issue? What browser(s) and OS |
| 42 | +experience the problem? Do other browsers show the bug differently? What |
| 43 | +would you expect to be the outcome? All these details will help people to fix |
| 44 | +any potential bugs. |
| 45 | + |
| 46 | +Example: |
| 47 | + |
| 48 | +> Short and descriptive example bug report title |
| 49 | +> |
| 50 | +> A summary of the issue and the browser/OS environment in which it occurs. If |
| 51 | +> suitable, include the steps required to reproduce the bug. |
| 52 | +> |
| 53 | +> 1. This is the first step |
| 54 | +> 2. This is the second step |
| 55 | +> 3. Further steps, etc. |
| 56 | +> |
| 57 | +> `<url>` - a link to the reduced test case |
| 58 | +> |
| 59 | +> Any other information you want to share that is relevant to the issue being |
| 60 | +> reported. This might include the lines of code that you have identified as |
| 61 | +> causing the bug, and potential solutions (and your opinions on their |
| 62 | +> merits). |
| 63 | +
|
| 64 | +## Feature requests |
| 65 | + |
| 66 | +Feature requests are welcome. Before opening a feature request, please take a |
| 67 | +moment to find out whether your idea fits with the scope and aims of the |
| 68 | +project. It's up to *you* to make a strong case to convince the project's |
| 69 | +developers of the merits of this feature. Please provide as much detail |
| 70 | +and context as possible. |
| 71 | + |
| 72 | + |
| 73 | +## Pull requests |
| 74 | + |
| 75 | +Good pull requests—patches, improvements, new features—are a fantastic |
| 76 | +help. They should remain focused in scope and avoid containing unrelated |
| 77 | +commits. |
| 78 | + |
| 79 | +**Please ask first** before embarking on any significant pull request (e.g. |
| 80 | +implementing features, refactoring code, porting to a different language), |
| 81 | +otherwise you risk spending a lot of time working on something that the |
| 82 | +project's developers might not want to merge into the project. |
| 83 | + |
| 84 | +Adhering to the following process is the best way to get your work |
| 85 | +included in the project: |
| 86 | + |
| 87 | +1. [Fork](https://help.github.com/fork-a-repo/) the project, clone your fork, |
| 88 | + and configure the remotes: |
| 89 | + |
| 90 | + ```bash |
| 91 | + # Clone your fork of the repo into the current directory |
| 92 | + git clone https://github.com/<your-username>/coreui-angular.git |
| 93 | + # Navigate to the newly cloned directory |
| 94 | + cd coreui |
| 95 | + # Assign the original repo to a remote called "upstream" |
| 96 | + git remote add upstream https://github.com/coreui/coreui-angular.git |
| 97 | + ``` |
| 98 | + |
| 99 | +2. If you cloned a while ago, get the latest changes from upstream: |
| 100 | + |
| 101 | + ```bash |
| 102 | + git checkout master |
| 103 | + git pull upstream master |
| 104 | + ``` |
| 105 | + |
| 106 | +3. Create a new topic branch (off the main project development branch) to |
| 107 | + contain your feature, change, or fix: |
| 108 | + |
| 109 | + ```bash |
| 110 | + git checkout -b <topic-branch-name> |
| 111 | + ``` |
| 112 | + |
| 113 | +4. Commit your changes in logical chunks. Please adhere to these [git commit |
| 114 | + message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) |
| 115 | + or your code is unlikely to be merged into the main project. Use Git's |
| 116 | + [interactive rebase](https://help.github.com/articles/interactive-rebase) |
| 117 | + feature to tidy up your commits before making them public. |
| 118 | + |
| 119 | +5. Locally merge (or rebase) the upstream development branch into your topic branch: |
| 120 | + |
| 121 | + ```bash |
| 122 | + git pull [--rebase] upstream master |
| 123 | + ``` |
| 124 | + |
| 125 | +6. Push your topic branch up to your fork: |
| 126 | + |
| 127 | + ```bash |
| 128 | + git push origin <topic-branch-name> |
| 129 | + ``` |
| 130 | + |
| 131 | +7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/) |
| 132 | + with a clear title and description against the `master` branch. |
| 133 | + |
| 134 | +**IMPORTANT**: By submitting a patch, you agree to allow the project owners to |
| 135 | +license your work under the terms of the [MIT License](LICENSE). |
| 136 | + |
| 137 | +### Semantic Git commit messages |
| 138 | + |
| 139 | +Inspired by Sparkbox's awesome article on |
| 140 | +[semantic commit messages](http://seesparkbox.com/foundry/semantic_commit_messages). |
| 141 | +Please use following commit message format. |
| 142 | + |
| 143 | +* chore (updating npm tasks etc; no production code change) -> ```git test -m 'chore: commit-message-here'``` |
| 144 | +* docs (changes to documentation) -> ```git commit -m 'docs: commit-message-here'``` |
| 145 | +* feat (new feature) -> ```git commit -m 'feat: commit-message-here'``` |
| 146 | +* fix (bug fix) -> ```git commit -m 'fix: commit-message-here'``` |
| 147 | +* refactor (refactoring production code) -> ```git commit -m 'refactor: commit-message-here'``` |
| 148 | +* style (formatting, missing semi colons, etc; no code change) -> ```git commit -m 'style: commit-message-here'``` |
| 149 | +* test (adding missing tests, refactoring tests; no production code change) -> ```git test -m 'refactor: commit-message-here'``` |
| 150 | + |
| 151 | +## Code guidelines |
| 152 | + |
| 153 | +### HTML |
| 154 | + |
| 155 | +[Adhere to the Code Guide.](http://codeguide.co/#html) |
| 156 | + |
| 157 | +- Use tags and elements appropriate for an HTML5 doctype (e.g., self-closing tags). |
| 158 | +- Use CDNs and HTTPS for third-party JS when possible. We don't use protocol-relative URLs in this case because they break when viewing the page locally via `file://`. |
| 159 | +- Use [WAI-ARIA](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA) attributes in documentation examples to promote accessibility. |
| 160 | + |
| 161 | +### CSS |
| 162 | + |
| 163 | +[Adhere to the Code Guide.](http://codeguide.co/#css) |
| 164 | + |
| 165 | +- When feasible, default color palettes should comply with [WCAG color contrast guidelines](http://www.w3.org/TR/WCAG20/#visual-audio-contrast). |
| 166 | +- Except in rare cases, don't remove default `:focus` styles (via e.g. `outline: none;`) without providing alternative styles. See [this A11Y Project post](http://a11yproject.com/posts/never-remove-css-outlines) for more details. |
| 167 | + |
| 168 | +### TS |
| 169 | + |
| 170 | +- 2 spaces (no tabs) |
| 171 | +- strict mode |
| 172 | +- "Attractive" |
| 173 | +- Don't use [jQuery event alias convenience methods](https://github.com/jquery/jquery/blob/master/src/event/alias.js) (such as `$().focus()`). Instead, use [`$().trigger(eventType, ...)`](http://api.jquery.com/trigger/) or [`$().on(eventType, ...)`](http://api.jquery.com/on/), depending on whether you're firing an event or listening for an event. (For example, `$().trigger('focus')` or `$().on('focus', function (event) { /* handle focus event */ })`) We do this to be compatible with custom builds of jQuery where the event aliases module has been excluded. |
| 174 | + |
| 175 | +## License |
| 176 | + |
| 177 | +By contributing your code, you agree to license your contribution under the [MIT License](LICENSE). |
0 commit comments