Add multi-select drag & drop support for objectMultihref condition lists #2960
+27
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified objectMultihref.js to iterate through all selected records in data.records instead of only processing the first record. This enables users to select multiple data objects (products, categories, customers, etc.) and drag them all at once into condition lists. Fixes the issue where each data object had to be added individually to condition lists in cart price rules, product price rules, shipping rules, and other rule configurations. Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add drag and drop support for condition lists
Add multi-select drag & drop support for objectMultihref condition lists
Jan 29, 2026
dpfaffenbauer
approved these changes
Jan 29, 2026
dpfaffenbauer
requested changes
Jan 29, 2026
| } else { | ||
| return Ext.dd.DropZone.prototype.dropNotAllowed; | ||
| // Check if any of the records can be dropped | ||
| for (var i = 0; i < data.records.length; i++) { |
| type: data.className | ||
| }; | ||
| // Process all records in the drag selection | ||
| for (var i = 0; i < data.records.length; i++) { |
Address code review feedback to use for-of loops for simpler iteration over data.records arrays in both onNodeOver and onNodeDrop handlers. Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/CoreShop/Bundle/ResourceBundle/Resources/public/pimcore/js/object/objectMultihref.jsonNodeDrophandler only processesdata.records[0]instead of all recordsonNodeDropandonNodeOverhandlers to support multiple recordsonNodeOverto check if ANY of the dragged records can be droppedonNodeDropto iterate through all records and add each valid onefor-ofloops per code review feedbackOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.