files can't be overriden #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

dustymabe opened this issue Jul 30, 2020 · 1 comment

Member

dustymabe commented Jul 30, 2020

Currently if you put a file in:

/run/console-login-helper-messages/motd.d/30_foo.motd
/etc/console-login-helper-messages/motd.d/30_foo.motd

Then the contents of both files will get printed. Basically we don't allow for things to be overridden or canceled out, we just include it all.

This will probably be solved when we move to the native implementations of motd.d (#60) and issue.d (#7).

The text was updated successfully, but these errors were encountered:

dustymabe mentioned this issue

motdgen, issuegen: write staged changes to a tempfile #44

Merged

Member

kelvinfan001 commented Aug 26, 2020 •

edited

Loading

Looks like moving to the native implmentation of motd.d (#60) will solve this issue for motd via SSH (https://github.com/linux-pam/linux-pam/pull/69/files), but not motd via agetty --autologin (util-linux/util-linux@5a528e2).
Also might not work for issue.d (https://github.com/karelzak/util-linux/blob/d3f21dca1e4612cfd90e7a06dfabd6c767736ae6/term-utils/agetty.8#L127).
Thus, for issue.d and motd via agetty --autologin, if I'm understanding correctly, it might actually be easier to check for overrides under the current implementation of concatenating all .issue/.motd snippets into a final file to be read by agetty. It is unlikely that util-linux will support overrides upstream (util-linux/util-linux#1034 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment