feat(oci): add publishing of helm chart to oci repo #189
Conversation
|
Good work here, hopefully we can see it merged 🙏🏼 |
|
@mrueg what do you think of this? |
|
Do we need to enable anything else within the coredns org to support this? |
|
After the PR is merged and the OCI artifact is published you might need to make it public by visiting https://github.com/orgs/coredns/packages |
CC: @chrisohaver is that something you could help out with once it's merged? I don't think I have access to that. |
Sure, I can have that updated in a the next little bit
And you shouldn't need to enable anything else. |
- fixes coredns#182 - adds cosign keyless signing to actions Signed-off-by: Allen Conlon <[email protected]>
|
@mrueg updated the PR with the changes that you suggested. I also removed the https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md |
|
Thanks for your contribution! Please let me know if anything needs to change to make it work. |
|
It does look like the release failed https://github.com/coredns/helm/actions/runs/12977130359/job/36190205317 |
|
I will take a look.... |
|
@a1994sc I believe your missing the packages permission, I should have caught this sorry. permissions:
contents: write # for creating the GitHub release.
id-token: write # for creating OIDC tokens for signing.
packages: write # for pushing and signing container images. |
Why is this pull request needed and what does it do?
Which issues (if any) are related?
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.