Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple query detector fragile #2

Open
coolya opened this issue Mar 30, 2018 · 0 comments
Open

simple query detector fragile #2

coolya opened this issue Mar 30, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@coolya
Copy link
Owner

coolya commented Mar 30, 2018

At the moment the Helper.isSimple method only checks if there is a single statement in the statements list this will break easily.

It should whitelist actual statements that are known to work like the ExpressionStatement.
@coolya coolya added enhancement New feature or request good first issue Good for newcomers labels Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coolya