Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# anchor doesn't work in 2c-r layout #108

Open
martinbon opened this issue Mar 17, 2021 · 5 comments
Open

# anchor doesn't work in 2c-r layout #108

martinbon opened this issue Mar 17, 2021 · 5 comments

Comments

@martinbon
Copy link

Demo clip
https://share.clickup.com/clip/p/t2317190/274a95ec-1f12-4064-a585-7ad5505e26ea/screen-recording-2021-03-17-13:20.webm

Example URL
https://cxl.com/institute/lesson/a-big-list-of-persuasion-techniques/#context-dependent-memory

Scroll is working with scroll="document", but not supported with scroll="panels".
image

@martinbon
Copy link
Author

martinbon commented Mar 17, 2021

Comment from @tomasced:

Had a look more and it turns out it doesn't work with 2c-r layout:
<cxl-app-layout id="container" class="cxl-app-layout" layout="2c-r" wide="" scroll="panels">
You can go to https://cxl.com/institute/online-course/adobe-analytics/#get-a-lesson-preview and change to "panels" and leave layout as 1c.
<cxl-app-layout id="container" class="cxl-app-layout" layout="1c" wide="" scroll="panels">
it works, but as soon you change it to 2c-r layout, it stops working (with two columns)

@martinbon martinbon changed the title ID # anchors doesn't work with scroll="panels" # anchor doesn't work in 2c-r layout Mar 17, 2021
@anoblet
Copy link
Collaborator

anoblet commented Apr 15, 2021

@lkraav
Copy link

lkraav commented Apr 15, 2021

I believe I have this fixed. Here is a demo:

Code?

@anoblet
Copy link
Collaborator

anoblet commented Apr 15, 2021

anoblet#7

@lkraav
Copy link

lkraav commented Apr 15, 2021

Looks promising.

Any side effects to address from http://harttle.land/scroll-restoration-demos/ perhaps?

@anoblet anoblet linked a pull request Apr 15, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants