Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

🔶 - Implement service prerequisites collection #316

Open
petrspelos opened this issue Aug 30, 2020 · 0 comments
Open

🔶 - Implement service prerequisites collection #316

petrspelos opened this issue Aug 30, 2020 · 0 comments
Assignees
Labels
advanced This is a non-trivial issue Core Work on Miunie.Core and Discord
Milestone

Comments

@petrspelos
Copy link
Member

petrspelos commented Aug 30, 2020

Summary

Service prerequisites collection is one of our Command Pipeline steps with the following purpose:

  • It Creates a new instance of a MiunieContext object and fills the appropriate properties
    • MiunieContext should mostly contain IDs (MessageId, ChannelId, etc.)
    • On top of that, MiunieContext should contain helper getters such as MessageIsInDm
  • It finds the best matching MiunieCommand from the provided list in its InputObject passed from the previous step
    • Matching is based on the number of parameters and their type
  • It parses command parameters into appropriate types and invokes the best matching command

How to implement

Creation of a new Command Pipeline step is needed.

Furthermore, helper interfaces such as ICommandFactory (and possibly other) is going to be needed. The implementation of these is not part of this issue.

Interested? 😊

If you'd like to help us by solving this issue, just say so in the comments. ❤️
And don't shy away from asking any kind of question you might have.

Should you have any questions at all, feel free to contact either me (@petrspelos) or @DraxCodes on our Discord server:

Discord

And of course, thank you so much for contributing! 🎉 It's because of amazing people like yourself that Miunie exists.

@petrspelos petrspelos added up-for-grabs Issue open for taking needs more info needs to be fleshed out blocked Cannot be completed. labels Aug 30, 2020
@petrspelos petrspelos added this to the Miunie 2.0 milestone Aug 30, 2020
@petrspelos petrspelos added Core Work on Miunie.Core and Discord and removed blocked Cannot be completed. labels Aug 30, 2020
@petrspelos petrspelos added advanced This is a non-trivial issue and removed needs more info needs to be fleshed out up-for-grabs Issue open for taking labels Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
advanced This is a non-trivial issue Core Work on Miunie.Core and Discord
Projects
None yet
Development

No branches or pull requests

2 participants