fix(shared): base initial disabled state on sdk.field.getIsDisabled() [TOL-2914] (#1852)

Author: z0al

packages/_shared/src/FieldConnector.test.tsx

@@ -6,11 +6,11 @@ import noop from 'lodash/noop';
 
 import { FieldConnector, FieldConnectorChildProps } from './FieldConnector';
 
-it('does not rerender with outdated value after calling setValue', async () => {
-  function getChild(): FieldConnectorChildProps<any> {
-    return props.children.mock.calls[props.children.mock.calls.length - 1][0];
-  }
+function getChild(children: any): FieldConnectorChildProps<any> {
+  return children.mock.calls[children.mock.calls.length - 1][0];
+}
 
+it('does not rerender with outdated value after calling setValue', async () => {
   const onSchemaErrorsChanged = jest.fn();
   const [field] = createFakeFieldAPI((field: any) => {
     return {
@@ -30,7 +30,7 @@ it('does not rerender with outdated value after calling setValue', async () => {
 
   render(<FieldConnector {...props} />);
 
-  let child = getChild();
+  let child = getChild(props.children);
   expect(child.value).toBe('initial value');
   const initialRenderCount = props.children.mock.calls.length;
 
@@ -40,9 +40,40 @@ it('does not rerender with outdated value after calling setValue', async () => {
 
   onSchemaErrorsChanged.mock.calls.forEach(([cb]) => cb([]));
 
-  child = getChild();
+  child = getChild(props.children);
   expect(child.value).toBe('new value');
 
   // to ensure that there was actually a rerender after calling `setValue` as we want to test that we don't rerender with outdated data
   expect(props.children.mock.calls.length).toBeGreaterThan(initialRenderCount);
 });
+
+it('takes initial disable state from sdk.field', () => {
+  const [field] = createFakeFieldAPI((field: any) => {
+    return {
+      ...field,
+      // this promise never resolves
+      getIsDisabled: jest.fn().mockReturnValue(true),
+    };
+  }, 'initial value');
+
+  const props = {
+    isInitiallyDisabled: false,
+    children: jest.fn().mockImplementation(() => null),
+    field,
+    debounce: 0,
+  };
+
+  render(<FieldConnector {...props} />);
+
+  const child = getChild(props.children);
+  expect(child.value).toBe('initial value');
+
+  expect(field.getIsDisabled).toHaveBeenCalled();
+
+  expect(props.children).toHaveBeenCalledTimes(1);
+  expect(props.children).toHaveBeenCalledWith(
+    expect.objectContaining({
+      disabled: true,
+    })
+  );
+});

packages/_shared/src/FieldConnector.ts

@@ -67,7 +67,7 @@ export class FieldConnector<ValueType> extends React.Component<
       externalReset: 0,
       value: initialValue,
       lastRemoteValue: initialValue,
-      disabled: props.isInitiallyDisabled ?? false,
+      disabled: props.isInitiallyDisabled || props.field.getIsDisabled(),
       errors: [],
     };
   }

packages/reference/src/resources/testHelpers/resourceEditorHelpers.ts

@@ -10,6 +10,7 @@ export function mockSdkForField(fieldDefinition: any, fieldValue?: any): FieldAp
       onSchemaErrorsChanged: () => {},
       // eslint-disable-next-line -- test helper
       onIsDisabledChanged: () => {},
+      getIsDisabled: () => false,
       // eslint-disable-next-line -- test helper
       onValueChanged: () => {},
       ...fieldDefinition,