acbuild script does not work

[dimas]

In the same directory:

# acbuild run -- ls
bin  boot  dev	etc  home  lib	lib64  media  mnt  opt	proc  root  run  sbin  srv  sys  tmp  usr  var

# echo run -- ls > scr

# cat scr
run -- ls

# acbuild script scr
Running: [ls]
run: no build in progress in this working dir - try "acbuild begin"
script: no build in progress in this working dir - try "acbuild begin"
script: exit status 1

# acbuild run -- ls
bin  boot  dev	etc  home  lib	lib64  media  mnt  opt	proc  root  run  sbin  srv  sys  tmp  usr  var

[cgonyeo]

Even in script mode the begin command is still necessary.

Take a look at the example here: https://github.com/containers/build/blob/master/Documentation/subcommands/script.md#example

[cgonyeo]

And after reading over IRC backlog I should probably also mention that an acbuild script runs in an ephemeral directory under /tmp, so any build you have in progress in the current directory isn't touched by the acbuild script command.

[dimas]

Oh. I misunderstood it then. Couple of notes though:

• I bet I won't be the only one falling for this - when you have "acbuild run", "acbuild mount add", "acbuild begin" etc, "acbuild script" does not look like alternative to them - it reads more like yet another operation you can run in the middle of the build. Another operation that just allows you read actual operations from a file. I saw, you have a separate binary acbuild-script - have you considered not introducing "script" command to acbuild then but offer users who want to use script just run acbuild-script instead? This way it is a different binary and it is easier to appreciate differences in operarations
• I saw the page you linking before but unfortunately it was not obvious from it. Neither was that ephemeral thing mentioned there. So some doc update would help I guess
  Thanks

[cgonyeo]

I think I could make it less misleading by changing the language in acbuild --help. Right now it says "Runs an acbuild script", maybe "Run a build with steps specified in a file" would be clearer?

There's also nothing stopping users from directly using acbuild-script, I'm not sure how I feel about making it the only way to use scripts though.