Skip to content

Improvement request: Remove special characters for image tags #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mpsOxygen opened this issue Jun 28, 2024 · 2 comments · May be fixed by #23
Open

Improvement request: Remove special characters for image tags #19

mpsOxygen opened this issue Jun 28, 2024 · 2 comments · May be fixed by #23

Comments

@mpsOxygen
Copy link

Chart proxy has worked awesome until now, but I have the following issue which isn't chartproxy's fault but I think could be solved by it:

I am trying to pull the following charts into Harbor: https://SonarSource.github.io/helm-chart-sonarqube

While chartproxy transforms the chart into oci format pushing it into harbor fails because it has a + in the tag name, for example: sonarqube-dce:10.5.0+2748

It would be useful if chartproxy could remove the + and everything after it.
@Vad1mo
Copy link
Contributor

Vad1mo commented Jun 28, 2024

good point, it we should check into the issue. However I don't think it is solvable, truncating after the +, would cause unpredictable behavior. Maybe converting charcters eg + -> - or _ would be an option

@mpsOxygen
Copy link
Author

So I played some more with it and it seems the problem isn't with Harbor, but with chartproxy, it can't pull the helm chart because of the + sign.

Harbor is just fine with it when pushing it manually, it automatically changes the + (plus) to an _ (underscore).

user@fedora:~/proiecte/sonarqube/helm$ helm push sonarqube-dce-10.5.1+2816.tgz oci://harbor.company.com/repl-sonarqube-test
Pushed: harbor.company.com/repl-sonarqube-test/sonarqube-dce:10.5.1_2816
Digest: sha256:b9876fa2a76e7ecde1a75b48de25e847d694482f839f650e29b80d8dc586acb6
harbor.company.com/repl-sonarqube-test/sonarqube-dce:10.5.1_2816 contains an underscore.

OCI artifact references (e.g. tags) do not support the plus sign (+). To support
storing semantic versions, Helm adopts the convention of changing plus (+) to
an underscore (_) in chart version tags when pushing to a registry and back to
a plus (+) when pulling from a registry.

@EStork09 EStork09 linked a pull request Oct 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added handler for OCI Artifacts not supporting the plus sign (+) EStork09/helm-charts-oci-proxy
2 participants
@Vad1mo @mpsOxygen