Skip to content

Remove PartialEq::ne implementation #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtolnay opened this issue Jan 31, 2017 · 2 comments
Closed

Remove PartialEq::ne implementation #74

dtolnay opened this issue Jan 31, 2017 · 2 comments

Comments

@dtolnay
Copy link
Contributor

dtolnay commented Jan 31, 2017

The build is currently failing with this error:

error: re-implementing `PartialEq::ne` is unnecessary
   --> src/lib.rs:686:5
    |
686 |       fn ne(&self, other: &Self) -> bool {
    |  _____^ starting here...
687 | |         self.len() != other.len() || self.iter().ne(other)
688 | |     }
    | |_____^ ...ending here
    |
note: lint level defined here
   --> src/lib.rs:35:38
    |
35  | #![cfg_attr(feature = "clippy", deny(clippy))]
    |                                      ^^^^^^
    = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#partialeq_ne_impl
@apasel422
Copy link
Contributor

I'd accept a PR.

@apasel422
Copy link
Contributor

Fixed by #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants