refactor: extract offsetSet() implementation into separate methods

Author: Thorsten Suckow-Homberg

src/Core/AbstractList.php

@@ -142,24 +142,37 @@ public function peek(): mixed
     }
 
 
-// -------------------------
-//  ArrayAccess Interface
-// -------------------------
-
     /**
-     * @inheritdoc
+     * @param mixed $offset
+     * @param mixed $value
+     * @return void
      *
-     * @throws TypeError|OutOfBoundsException if $value is not of the type defined
-     * with this getEntityType, or f $offset is not an int
+     * @throws OutOfBoundsException
      */
-    public function offsetSet(mixed $offset, mixed $value): void
+    protected function doInsert(mixed $offset, mixed $value)
     {
-        if (!is_null($offset) && !is_int($offset)) { // @phpstan-ignore-line
+        if (!is_null($offset) && !is_int($offset)) {
             throw new OutOfBoundsException(
                 "expected integer key for \"offset\", " .
-                "but got \"$offset\" (type: " . (gettype($offset)) . ")"
+                "but got type: " . (gettype($offset))
             );
         }
+
+        if (is_null($offset)) {
+            $this->data[] = $value;
+        } else {
+            $this->data[$offset] = $value;
+        }
+    }
+
+    /**
+     * @param mixed  $value
+     * @return bool
+     *
+     * @throws TypeError
+     */
+    protected function assertTypeFor(mixed $value): bool
+    {
         $entityType = $this->getEntityType();
 
         // instanceof has higher precedence, do
@@ -172,14 +185,26 @@ public function offsetSet(mixed $offset, mixed $value): void
             );
         }
 
-        if (is_null($offset)) {
-            $this->data[] = $value;
-        } else {
-            $this->data[$offset] = $value;
-        }
+        return true;
     }
 
 
+// -------------------------
+//  ArrayAccess Interface
+// -------------------------
+
+    /**
+     * @inheritdoc
+     *
+     * @throws TypeError|OutOfBoundsException if $value is not of the type defined
+     * with this getEntityType, or f $offset is not an int
+     */
+    public function offsetSet(mixed $offset, mixed $value): void
+    {
+        $this->assertTypeFor($value);
+        $this->doInsert($offset, $value);
+    }
+
 
     /**
      * @inheritdoc

tests/Core/AbstractListTest.php

@@ -72,7 +72,7 @@ public function testOffsetSetWithStringAndOutOfBoundsException(): void
         $this->expectException(OutOfBoundsException::class);
 
         $abstractList = $this->getMockForAbstractList();
-        $abstractList["1"] = "foo";
+        $abstractList["1"] = new stdClass();
     }