Skip to content

Test gap: StreamProgressBar.tsx and StreamTimeline.tsx have no test coverage #324

Description

@Jaydbrown

Both components/stream/StreamProgressBar.tsx and components/stream/StreamTimeline.tsx contain real, non-trivial time-based percentage/pause-marker math (open-ended stream handling, clamping, pausedAt offset calculation), but neither has a corresponding test file. This is exactly the kind of "non-trivial conditional logic in components" CONTRIBUTING.md's own Testing section says should be tested ("test the logic, not the rendering"). Given the paused-state calculation bug reported separately in this batch (StreamProgressBar not receiving/using pausedAt at all), a test file for these two components would have caught that regression directly by asserting the rendered aria-valuenow/width for a paused stream stays pinned at pausedAt, not at Date.now().

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions