Skip to content

Conversation

@bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Sep 29, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

References:

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bpf-linker/recipe.yaml) and found it was in an excellent condition.

@bollwyvl bollwyvl marked this pull request as ready for review September 29, 2025 23:54
@bollwyvl
Copy link
Contributor Author

@conda-forge/help-rust ready for review

@bollwyvl
Copy link
Contributor Author

@conda-forge/help-rust ready for review

Copy link
Contributor

@danielnachun danielnachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make only one small change here to add some environment variables we want to set for Rust packages and now this ready to merge.

@danielnachun danielnachun merged commit 8d6cd05 into conda-forge:main Oct 15, 2025
7 checks passed
@bollwyvl
Copy link
Contributor Author

Thanks! On to the rest of the yakshave 💈 !

add some environment variables

Good catch!

This is another one of those things it would be lovely to transfer from tribal wisdom to something automated. I imagine using a declarative, multi-file linter like semgrep or gritql. I particularly like gritql's markdown approach as it leads to outcomes like "one rule per file, the name of which becomes the rule id", which is pretty hard to do after the fact.

@bollwyvl bollwyvl deleted the add-bpf-linker branch October 15, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants