Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chafa and fastfetch #26240

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add chafa and fastfetch #26240

wants to merge 1 commit into from

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented May 4, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/chafa, recipes/fastfetch) and found it was in an excellent condition.

@peterjc
Copy link
Contributor

peterjc commented Dec 28, 2024

Doing two packages in one PR was probably a mistake - they don't depend on each other, do they?

@pavelzw
Copy link
Member Author

pavelzw commented Dec 28, 2024

Fastfetch depends on Chafa

@peterjc
Copy link
Contributor

peterjc commented Dec 29, 2024

I missed that, but I don't think you'd be able to package fastfetch until after chafa is packaged. May is long enough ago that the failed run logs have gone, so we don't know how it failed.

Can you try cutting this down to just chafa? [I found this issue as I was interested in seeing chafa packaged, again as a dependency of something else]

@pavelzw
Copy link
Member Author

pavelzw commented Dec 29, 2024

Back then, chafa wasn't the issue but something else in fastfetch.

Conda-build is smart enough to first build chafa and then fastfetch in this ci. You might need to restart fastfetch's ci on feedstock creation though.
We could give chafa a try in a separate PR if you need it for an unrelated PR, though

@peterjc peterjc mentioned this pull request Dec 29, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants