Skip to content

Commit c7613e2

Browse files
ndeloofglours
authored andcommitted
prefer slices.Collect
Signed-off-by: Nicolas De Loof <[email protected]>
1 parent 23db21a commit c7613e2

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

types/project.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -121,21 +121,21 @@ func (p *Project) ServicesWithBuild() []string {
121121
servicesBuild := p.Services.Filter(func(s ServiceConfig) bool {
122122
return s.Build != nil && s.Build.Context != ""
123123
})
124-
return slices.AppendSeq(make([]string, 0), maps.Keys(servicesBuild))
124+
return slices.Collect(maps.Keys(servicesBuild))
125125
}
126126

127127
func (p *Project) ServicesWithExtends() []string {
128128
servicesExtends := p.Services.Filter(func(s ServiceConfig) bool {
129129
return s.Extends != nil && *s.Extends != (ExtendsConfig{})
130130
})
131-
return slices.AppendSeq(make([]string, 0), maps.Keys(servicesExtends))
131+
return slices.Collect(maps.Keys(servicesExtends))
132132
}
133133

134134
func (p *Project) ServicesWithDependsOn() []string {
135135
servicesDependsOn := p.Services.Filter(func(s ServiceConfig) bool {
136136
return len(s.DependsOn) > 0
137137
})
138-
return slices.AppendSeq(make([]string, 0), maps.Keys(servicesDependsOn))
138+
return slices.Collect(maps.Keys(servicesDependsOn))
139139
}
140140

141141
func (p *Project) ServicesWithCapabilities() ([]string, []string, []string) {

types/project_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -283,13 +283,13 @@ func TestWithServices(t *testing.T) {
283283

284284
func TestServicesWithBuild(t *testing.T) {
285285
p := makeProject()
286-
assert.DeepEqual(t, []string{}, p.ServicesWithBuild())
286+
assert.Equal(t, len(p.ServicesWithBuild()), 0)
287287

288288
service, err := p.GetService("service_1")
289289
assert.NilError(t, err)
290290
service.Build = &BuildConfig{}
291291
p.Services["service_1"] = service
292-
assert.DeepEqual(t, []string{}, p.ServicesWithBuild())
292+
assert.Equal(t, len(p.ServicesWithBuild()), 0)
293293

294294
service.Build = &BuildConfig{
295295
Context: ".",

0 commit comments

Comments
 (0)