Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Installer machine needed for MSVC #1331

Open
partouf opened this issue Jun 18, 2024 · 5 comments
Open

Windows Installer machine needed for MSVC #1331

partouf opened this issue Jun 18, 2024 · 5 comments
Assignees
Labels

Comments

@partouf
Copy link
Member

partouf commented Jun 18, 2024

Need a throw-away instance that we can start each time we want to package a new MSVC version.

Scripts in https://github.com/compiler-explorer/infra/tree/main/msvc-install were used to get a lot of versions, but is obviously not recommended for normal use.

Idea is to:

  • launch a fresh instance
  • pass the URL to an install script (called from a manual workflow?)
  • it downloading the installer from that url
  • install the buildtools
  • rename the msvc compiler dir to $compilerVersion-$productVersion
  • zip up that directory
  • upload to s3
  • shutdown

Possible problems:

  • We'll only know the productVersion after the compiler has been installed (productVersion is unique, compilerVersion is not)
  • So only after it's know you could use msvc-install/gen-props.ps1 to see how the properties would look
  • probably much more...
@mattgodbolt mattgodbolt self-assigned this Jun 23, 2024
@mattgodbolt
Copy link
Member

Looking for what "the URL" is here currently :) MS's website is... not helpful here

@mattgodbolt
Copy link
Member

mattgodbolt commented Jun 23, 2024

We might be able to coerce packer into doing all this for us. Will dig about.

Update: Mayybe; we can make it skip_create_ami: true to skip making the AMI, and then get it to upload the ZIP to S3 directly. We'd be using packer as a "convenient" way to fire up an AMI, run something, and then shut it down only. That might be ok?

@partouf
Copy link
Member Author

partouf commented Jun 23, 2024

@mattgodbolt
Copy link
Member

Thanks!

@mattgodbolt
Copy link
Member

Partly done. Will leave this open til we're happy with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants