Refactor: Make dataclasses frozen, slots and kw_only where possible (#119)

Author: vrslev

auto_typing_final/finder.py

@@ -172,7 +172,7 @@ def has_global_identifier_with_name(root: SgNode, name: str) -> bool:
     return name in {identifier.text() for identifier, _ in _find_identifiers_in_current_scope(root)}
 
 
-@dataclass
+@dataclass(slots=True, kw_only=True)
 class ImportsResult:
     module_aliases: set[str]
     has_from_import: bool

auto_typing_final/lsp.py

@@ -75,7 +75,7 @@ def make_text_edit(edit: Edit) -> lsp.TextEdit:
     )
 
 
-@dataclass
+@dataclass(frozen=True, slots=True, kw_only=True)
 class Service:
     ls_name: str
     ignored_paths: list[Path]

auto_typing_final/transform.py

@@ -12,7 +12,7 @@
 )
 
 
-@dataclass
+@dataclass(frozen=True, slots=True, kw_only=True)
 class ImportConfig:
     value: str
     import_text: str
@@ -26,35 +26,35 @@ class ImportConfig:
 }
 
 
-@dataclass
+@dataclass(frozen=True, slots=True)
 class EditableAssignmentWithoutAnnotation:
     node: SgNode
     left: str
     right: str
 
 
-@dataclass
+@dataclass(frozen=True, slots=True)
 class EditableAssignmentWithAnnotation:
     node: SgNode
     left: str
     annotation: SgNode
     right: str
 
 
-@dataclass
+@dataclass(frozen=True, slots=True)
 class OtherDefinition:
     node: SgNode
 
 
 Definition = EditableAssignmentWithoutAnnotation | EditableAssignmentWithAnnotation | OtherDefinition
 
 
-@dataclass
+@dataclass(frozen=True, slots=True)
 class AddFinal:
     node: Definition
 
 
-@dataclass
+@dataclass(frozen=True, slots=True)
 class RemoveFinal:
     nodes: list[Definition]
 
@@ -174,20 +174,19 @@ def _make_changed_text_from_operation(
                                 yield node, f"{left}: {new_annotation} = {right}"
 
 
-# TODO: make dataclasses frozen and all other stuff  # noqa: FIX002, TD002, TD003
-@dataclass
+@dataclass(frozen=True, slots=True)
 class Edit:
     node: SgNode
     new_text: str
 
 
-@dataclass
+@dataclass(frozen=True, slots=True)
 class Replacement:
     operation_type: type[Operation]
     edits: list[Edit]
 
 
-@dataclass
+@dataclass(frozen=True, slots=True)
 class MakeReplacementsResult:
     replacements: list[Replacement]
     import_text: str | None