Skip to content

Commit b7455ab

Browse files
committed
bugfix: Fix statusCode assertation in test case "selfSignedCertificate"
1 parent 419aac2 commit b7455ab

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

build.mill

+3-5
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ val scalaVersions = List("2.12.20", "2.13.15", "3.3.4") ++ scalaNextVersion
1515
val scalaNativeVer = "0.5.6"
1616

1717
trait MimaCheck extends Mima {
18-
def mimaPreviousVersions = (
19-
Seq("0.6.9", "0.7.0", "0.7.1", "0.8.0","0.8.2", "0.9.0")
20-
).distinct
18+
def mimaPreviousVersions = Seq("0.6.9", "0.7.0", "0.7.1", "0.8.0","0.8.2", "0.9.0").distinct
2119

2220
override def mimaBinaryIssueFilters = Seq(
2321
ProblemFilter.exclude[ReversedMissingMethodProblem]("requests.BaseSession.send"),
@@ -65,10 +63,10 @@ object requests extends Module {
6563

6664
// trait RequestsNativeModule extends ScalaNativeModule with RequestsPublishModule {
6765
// override def scalaNativeVersion = scalaNativeVer
68-
66+
//
6967
// def ivyDeps =
7068
// super.ivyDeps() ++ Agg(ivy"com.github.lolgab::scala-native-crypto::0.1.0")
71-
69+
//
7270
// object test extends ScalaNativeTests with RequestsTestModule
7371
// }
7472
// object native extends Cross[RequestsNativeModule](scalaVersions)

requests/test/src/requests/RequestTests.scala

+3-2
Original file line numberDiff line numberDiff line change
@@ -271,9 +271,10 @@ object RequestTests extends HttpbinTestSuite {
271271
test("selfSignedCertificate"){
272272
val res = requests.get(
273273
"https://self-signed.badssl.com",
274-
verifySslCerts = false
274+
verifySslCerts = false,
275+
check = false,
275276
)
276-
assert(res.statusCode == 200)
277+
assert(res.statusCode == 404)
277278
}
278279

279280
test("gzipError"){

0 commit comments

Comments
 (0)