Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small edits for Loughborough Historians group #378

Open
9 of 14 tasks
MKIM1008 opened this issue Nov 12, 2024 · 8 comments
Open
9 of 14 tasks

Small edits for Loughborough Historians group #378

MKIM1008 opened this issue Nov 12, 2024 · 8 comments
Assignees

Comments

@MKIM1008
Copy link
Collaborator

MKIM1008 commented Nov 12, 2024

Sign-up section

  • On the post-sign-up page, make the Start Colouring button bigger and yellow background. (grey for the API button)

  • Please remove the logos on the bottom of the landing page and add them on the bottom of the sign-up page (Polly will check the key organisations.)

Top-contributors page

General items

  • Talk to @matkoniecz about the zoom options - not urgent until next week. - test on staging website for future discussion (greater than z19 zoom in)

  • Please can you add the search and layer features on the interface so that users can see these as soon as they land on the colouring britain page.
    image
    image

  • Please change the top & main body's Colouring Britain text font to the 1/2 size and the same as Age & History font, and increase spacing slightly.
    image

  • Please change the wording from "Select any building to view data options" to "Select a building to add, view or amend the data".
    image

  • We need to show on all the dropdowns that these are dropdowns not just grey boxes. Suggest we put the down-arrow to click in the grey box.

  • Can you check if they can't add data unless they edit the source? If they don't, a red information button will come up to tell them they need to complete this.
    image

  • In source type dropdown please change "professional knowledge" to "expert knowledge" for all categories. (e.g. https://colouringbritain.org/edit/age-history/3774771)
    image

In Cladding, Extention, Retrofit section

  • Please add 3 more long blue buttons to link to 3 more maps on A. Cladding B. Extension C. Retrofit. (when you add data here we currently have no coloured maps for the sections). Use the age key for all of these.
    image
  • Please add a + button so that multiple items can be added for all of them (Cladding Extension Retrofit).

In Lifespan section

  • Please remove the yellow box
    image

In Survival map section

  • When you choose an editable 1890 historical map with modern footprints you can't remove it by clicking the editable building layer. Can you do this please?
@matkoniecz
Copy link

Last one appears when "OS 1890s Historical Map + Footprints on" is combined with "Editable buildings on", always the same layer

@MKIM1008
Copy link
Collaborator Author

MKIM1008 commented Nov 15, 2024

Last one appears when "OS 1890s Historical Map + Footprints on" is combined with "Editable buildings on", always the same layer

For your reference about the Leicester 1900s map license
: Courtesy of the National Library of Scotland’
…as an attribution, preferably linking to https://maps.nls.uk/

Please see Christopher's email I copied to you.

@matkoniecz
Copy link

matkoniecz commented Nov 18, 2024

on the right side: remove EditableBuildingsSwitcher, remove all historical map switchers

add nested "Historical Maps" switcher which after clicking unrolls option to enable London historical map and Leicestershire historical map (keeping current names)


add Leicestershire map to left side, in survival tracking

@matkoniecz
Copy link

matkoniecz commented Nov 18, 2024

"Click to show the historical maps which you can edit building survival on." that would enable both historical maps AND add footprints AND switch to survival data (including legend)

@matkoniecz
Copy link

matkoniecz commented Nov 18, 2024

"Current Building on Previous Green Space" to "Current Building on Previously Unbuilt-on Site"

@matkoniecz
Copy link

Please change the top & main body's Colouring Britain text font to the 1/2 size and the same as Age & History font, and increase spacing slightly.

I will not interpret it literally, as 1/2 size is a bit too much.

I reduced it noticeably and increased spacing between words.

Please let me know if it was supposed to be 1/2 size of original and tiny or if I was supposed to decrease text size more.

@polly64


actually 1/2:

screen03


what I did for now:

screen04


original:

screen05

matkoniecz added a commit to matkoniecz/colouring-core that referenced this issue Nov 22, 2024
matkoniecz added a commit to matkoniecz/colouring-core that referenced this issue Nov 22, 2024
displays triangle symbol on the right side of select data entry

part of colouring-cities#378
matkoniecz added a commit that referenced this issue Nov 22, 2024
matkoniecz added a commit that referenced this issue Nov 22, 2024
@matkoniecz
Copy link

matkoniecz commented Dec 4, 2024

allow no source links if "no source link available"

if another user adds link, it will remove this marking

@matkoniecz
Copy link

matkoniecz commented Dec 4, 2024

user A in past: added age, without source

we start requirement to require source

user B: wants to add another field. Should they be blocked from doing so if age is without source, until source is added?

answer: the should be allowed

but they should not be allowed to change age field without giving source to age field

(the same not only for age but also any other field)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants