Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop unsupported versions of PHP #31

Open
tacman opened this issue Nov 22, 2024 · 1 comment
Open

drop unsupported versions of PHP #31

tacman opened this issue Nov 22, 2024 · 1 comment

Comments

@tacman
Copy link
Contributor

tacman commented Nov 22, 2024

Detailed description

Since 8.0 is at EOL, what do you think of bumping the minimum version of php to only supported versions?

Even 8.1 is on life support (security fixes only). Mostly to take advantage of the more static analysis tools with the later versions of PHP.

I know, super-minor.

Thanks for releasing this, I've been playing around with it, especially the CI, and learning lots just from seeing how you've set it up.

@colinodell
Copy link
Owner

Great question! Here's my personal philosophy on which PHP versions I target in my libraries:

  • For brand new libraries: Target the latest version only by default; take advantage of all the new language features that make sense to use
  • For existing libraries: Keep supporting the same versions I always have while adding support for newer ones; drop support after the version becomes EOL

But I also make one exception:

  • If the code I've written happens to just work on older PHP versions without needing any changes, then I'll continue to allow installation on those older versions, even if they are EOL.

So for this reason, I'll probably keep PHP 8.0 as an allowed, tested version for now until there's a real need for us to break compatibility.

Thanks for releasing this, I've been playing around with it, especially the CI, and learning lots just from seeing how you've set it up.

That's awesome to hear! I appreciate your kind words :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants