Converted AlreadyStarted error handling to use rpc status

Author: cvanderschuere

Diff for: lib/temporal/connection/grpc.rb

@@ -5,6 +5,7 @@
 require 'temporal/connection/serializer'
 require 'temporal/connection/serializer/failure'
 require 'gen/temporal/api/workflowservice/v1/service_services_pb'
+require 'gen/temporal/api/errordetails/v1/message_pb'
 require 'temporal/concerns/payloads'
 
 module Temporal
@@ -117,9 +118,13 @@ def start_workflow_execution(
 
         client.start_workflow_execution(request)
       rescue ::GRPC::AlreadyExists => e
-        # Feel like there should be cleaner way to do this...
-        run_id = e.details[/RunId: ([a-f0-9]+-[a-f0-9]+-[a-f0-9]+-[a-f0-9]+-[a-f0-9]+)/, 1]
-        raise Temporal::WorkflowExecutionAlreadyStartedFailure.new(e.details, run_id)
+        cast_error = e.to_rpc_status&.details&.map do |any_error|
+          next unless any_error.type_url == 'type.googleapis.com/temporal.api.errordetails.v1.WorkflowExecutionAlreadyStartedFailure'
+
+          any_error.unpack(Temporal::Api::ErrorDetails::V1::WorkflowExecutionAlreadyStartedFailure)
+        end&.compact&.first
+
+        raise Temporal::WorkflowExecutionAlreadyStartedFailure.new(e.details, cast_error&.run_id)
       end
 
       SERVER_MAX_GET_WORKFLOW_EXECUTION_HISTORY_POLL = 30

Diff for: spec/spec_helper.rb

@@ -16,6 +16,7 @@
 
 require 'temporal'
 require 'google/protobuf/well_known_types'
+require 'google/rpc/status_pb'
 require 'pry'
 
 Dir[File.expand_path('config/*.rb', __dir__)].sort.each { |f| require f }

Diff for: spec/unit/lib/temporal/grpc_client_spec.rb

@@ -4,20 +4,28 @@
   let(:namespace) { 'test-namespace' }
   let(:workflow_id) { SecureRandom.uuid }
   let(:run_id) { SecureRandom.uuid }
-  let(:now) { Time.now}
+  let(:now) { Time.now.utc }
+  let(:already_started_error) do
+    detail_error = Google::Protobuf::Any.new.tap do |any|
+      any.pack(Temporal::Api::ErrorDetails::V1::WorkflowExecutionAlreadyStartedFailure.new(start_request_id: SecureRandom.uuid, run_id: run_id))
+    end
+    rpc_status = Google::Rpc::Status.new(
+      code: 6,
+      message: 'Workflow execution already finished successfully. WorkflowId: TestWorkflow-1, RunId: baaf1d86-4459-4ecd-a288-47aeae55245d. Workflow Id reuse policy: allow duplicate workflow Id if last run failed.',
+      details: [detail_error],
+    )
+    GRPC::AlreadyExists.new('details', { 'grpc-status-details-bin' => Google::Rpc::Status.encode(rpc_status) })
+  end
 
   before do
     allow(subject).to receive(:client).and_return(grpc_stub)
-    
+
     allow(Time).to receive(:now).and_return(now)
   end
 
   describe '#start_workflow_execution' do
     it 'provides the existing run_id when the workflow is already started' do
-      allow(grpc_stub).to receive(:start_workflow_execution).and_raise(
-        GRPC::AlreadyExists,
-        'Workflow execution already finished successfully. WorkflowId: TestWorkflow-1, RunId: baaf1d86-4459-4ecd-a288-47aeae55245d. Workflow Id reuse policy: allow duplicate workflow Id if last run failed.'
-      )
+      allow(grpc_stub).to receive(:start_workflow_execution).and_raise(already_started_error)
 
       expect do
         subject.start_workflow_execution(
@@ -31,11 +39,11 @@
           memo: {}
         )
       end.to raise_error(Temporal::WorkflowExecutionAlreadyStartedFailure) do |e|
-        expect(e.run_id).to eql('baaf1d86-4459-4ecd-a288-47aeae55245d')
+        expect(e.run_id).to eql(run_id)
       end
     end
   end
-  
+
   describe '#signal_with_start_workflow' do
     let(:temporal_response) do
       Temporal::Api::WorkflowService::V1::SignalWithStartWorkflowExecutionResponse.new(run_id: 'xxx')
@@ -148,7 +156,7 @@
         end
       end
 
-      it 'demands a timeout to be specified' do 
+      it 'demands a timeout to be specified' do
         expect do
           subject.get_workflow_execution_history(
             namespace: namespace,
@@ -161,7 +169,7 @@
         end
       end
 
-      it 'disallows a timeout larger than the server timeout' do 
+      it 'disallows a timeout larger than the server timeout' do
         expect do
           subject.get_workflow_execution_history(
             namespace: namespace,