diff --git a/CHANGELOG.md b/CHANGELOG.md index be289d3..2b42db3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,8 @@ # Changelog +## [0.4.20] - 12/16/2025 +### Fixes +- Fix [#46](https://github.com/coffeegist/bofhound/issues/46) which caused well-known SIDs (groups) to be mising from bofhound output + ## [0.4.19] - 12/12/2025 ### Fixes - Fix [#47](https://github.com/coffeegist/bofhound/issues/47) diff --git a/bofhound/ad/models/bloodhound_group.py b/bofhound/ad/models/bloodhound_group.py index 6a5fc0f..231349f 100644 --- a/bofhound/ad/models/bloodhound_group.py +++ b/bofhound/ad/models/bloodhound_group.py @@ -37,11 +37,9 @@ def __init__(self, object): logger.debug(f"Reading Group object {ColorScheme.group}{name}[/]", extra=OBJ_EXTRA_FMT) if 'objectsid' in object.keys(): - #objectid = BloodHoundObject.get_sid(object.get('objectsid', None), object.get('distinguishedname', None)) objectid = object.get('objectsid') - self.ObjectIdentifier = objectid - self.Properties["domainsid"] = objectid.rsplit('-',1)[0] - + if objectid not in ADUtils.WELLKNOWN_SIDS: + self.Properties["domainsid"] = objectid.rsplit('-',1)[0] if 'distinguishedname' in object.keys(): self.Properties["distinguishedname"] = object.get('distinguishedname', None).upper() diff --git a/pyproject.toml b/pyproject.toml index 6ced22a..c17221d 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "bofhound" -version = "0.4.19" +version = "0.4.20" description = "Parse output from common sources and transform it into BloodHound-ingestible data" authors = [ "Adam Brown",