Add sponsor #1251
Add sponsor #1251
Conversation
|
@CarolinaCobo is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes introduce a new configuration constant and two new page components. A constant named Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant CP as Company Page Component
participant CC as Companies Config
U->>CP: Request page with slug parameter
CP->>CC: Lookup company using slug
alt Company exists
CC-->>CP: Return company details
CP-->>U: Render company information
else Company not found
CP-->>U: Invoke notFound (404 response)
end
sequenceDiagram
participant U as User
participant SP as Sponsorship Page
participant R as Router
U->>SP: Click on company image link
SP->>R: Navigate to /company/ninedots
R-->>U: Render corresponding company page
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
CarolinaCobo
temporarily deployed
to
production
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
app/(app)/sponsorship/page.tsx (1)
65-71: Update the alt text for consistencyThe alt text for the ninedots image is "StaticKit", which doesn't match the actual company being displayed. This should be updated to "Ninedots" for consistency and proper accessibility.
<img className="my-auto h-16" src="/images/sponsors/ninedots.png" - alt="StaticKit" + alt="Ninedots" />app/(app)/company/[slug]/config.ts (2)
5-6: Improve readability of long text stringsThe bio and note fields contain very long text strings that reduce code readability. Consider using template literals with line breaks for better maintainability.
- bio: "Trusted talent partner based in Dublin and Bahrain. We specialise in everything within the tech ecosystem, including marketing and tech sales. However, if we can't assist, we won't tell you we can. What we CAN do is steer you in the right direction - we believe it doesn't cost to be helpful!", - note: "We're incredibly grateful to Ninedots for supporting our tech community since April! Your generosity has helped us grow, bring people together, and create amazing learning opportunities through events, workshops, and networking sessions. Your support means the world to us, and we couldn't do this without you.Thanks for believing in our mission and being a part of our journey—we're excited for what's ahead!", + bio: `Trusted talent partner based in Dublin and Bahrain. We specialise in everything + within the tech ecosystem, including marketing and tech sales. However, if we can't assist, + we won't tell you we can. What we CAN do is steer you in the right direction - + we believe it doesn't cost to be helpful!`, + note: `We're incredibly grateful to Ninedots for supporting our tech community since April! + Your generosity has helped us grow, bring people together, and create amazing learning opportunities + through events, workshops, and networking sessions. Your support means the world to us, and + we couldn't do this without you. Thanks for believing in our mission and being a part of + our journey—we're excited for what's ahead!`,
6-6: Fix missing space in textThere's a missing space between "you." and "Thanks" in the note text.
- note: "We're incredibly grateful to Ninedots for supporting our tech community since April! Your generosity has helped us grow, bring people together, and create amazing learning opportunities through events, workshops, and networking sessions. Your support means the world to us, and we couldn't do this without you.Thanks for believing in our mission and being a part of our journey—we're excited for what's ahead!", + note: "We're incredibly grateful to Ninedots for supporting our tech community since April! Your generosity has helped us grow, bring people together, and create amazing learning opportunities through events, workshops, and networking sessions. Your support means the world to us, and we couldn't do this without you. Thanks for believing in our mission and being a part of our journey—we're excited for what's ahead!",app/(app)/company/[slug]/page.tsx (1)
66-71: Use Next.js Link component for navigationFor internal navigation, use the Next.js Link component instead of a regular anchor tag for better performance through client-side navigation.
- <a - href="/sponsorship" - className="text-sm font-medium text-neutral-500 hover:text-neutral-700 dark:text-neutral-400 dark:hover:text-neutral-300" - > - ← Back to all sponsors - </a> + <Link + href="/sponsorship" + className="text-sm font-medium text-neutral-500 hover:text-neutral-700 dark:text-neutral-400 dark:hover:text-neutral-300" + > + ← Back to all sponsors + </Link>Don't forget to add the import at the top:
+import Link from "next/link"; import { notFound } from "next/navigation"; import { companies } from "./config";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
public/images/sponsors/ninedots.pngis excluded by!**/*.png,!**/*.png
📒 Files selected for processing (3)
app/(app)/company/[slug]/config.ts(1 hunks)app/(app)/company/[slug]/page.tsx(1 hunks)app/(app)/sponsorship/page.tsx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: e2e
| export const metadata = { | ||
| title: "Ninedots Recruitment | Codu", | ||
| description: | ||
| "Explore our community sponsors. Ninedots Recruitment connects top talent with leading companies in the tech industry.", | ||
| }; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Make metadata dynamic based on company slug
The metadata is currently hardcoded for Ninedots, but this is a dynamic page that could support multiple companies. Consider making the metadata dynamic based on the company found by the slug.
-export const metadata = {
- title: "Ninedots Recruitment | Codu",
- description:
- "Explore our community sponsors. Ninedots Recruitment connects top talent with leading companies in the tech industry.",
-};
+export async function generateMetadata({ params }: Props) {
+ const { slug } = params;
+ const company = companies.find((item) => item.slug === slug.toLowerCase());
+
+ if (!company) return {};
+
+ return {
+ title: `${company.name} | Codu`,
+ description: `Explore our community sponsors. ${company.name} ${company.bio.substring(0, 100)}...`,
+ };
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export const metadata = { | |
| title: "Ninedots Recruitment | Codu", | |
| description: | |
| "Explore our community sponsors. Ninedots Recruitment connects top talent with leading companies in the tech industry.", | |
| }; | |
| export async function generateMetadata({ params }: Props) { | |
| const { slug } = params; | |
| const company = companies.find((item) => item.slug === slug.toLowerCase()); | |
| if (!company) return {}; | |
| return { | |
| title: `${company.name} | Codu`, | |
| description: `Explore our community sponsors. ${company.name} ${company.bio.substring(0, 100)}...`, | |
| }; | |
| } |
2 participants
✨ Codu Pull Request 💻
Fixes #(issue)
Pull Request details
Any Breaking changes
Associated Screenshots
[Optional] What gif best describes this PR or how it makes you feel