Skip to content

Commit d1629ea

Browse files
committed
fix reload on domain change, gulpfile tweak
1 parent fc88a6b commit d1629ea

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

gulpfile.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ const settings = {
2525
firefox: {
2626
source: './src/firefox',
2727
destination: 'firefox',
28-
extension: '.xpi'
28+
extension: 'xpi'
2929
},
3030
chrome: {
3131
source: './src/chrome',
3232
destination: 'chrome',
33-
extension: '.zip'
33+
extension: 'zip'
3434

3535
}
3636
}
@@ -117,7 +117,7 @@ const add_dev_server = function (manifest_stream) {
117117

118118
const package = function (options, zipped, for_dev){
119119
return (
120-
function({source, destination: dest, extension}, zipped, for_dev) {
120+
function({source, destination: dest, extension: ext}, zipped, for_dev) {
121121
return function() {
122122
console.log(`package source: ${source}`);
123123
let package_name, destination, package_stream;
@@ -128,10 +128,10 @@ const package = function (options, zipped, for_dev){
128128

129129
if (for_dev){
130130
manifest_stream = add_dev_server (manifest_stream)
131-
package_name = `${settings.name}-dev${extension}`
131+
package_name = `${settings.name}-${settings.version}.dev.${ext}`
132132
} else {
133133
js_stream.pipe(stripDebug())
134-
package_name = `${settings.name}-${settings.version}${extension}`
134+
package_name = `${settings.name}-${settings.version}.${ext}`
135135
}
136136
destination = for_dev ? dest : settings.destination
137137
console.log(`package dest: ${destination}`);

src/issue.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,19 @@ const make_widget = ({domain}) => {
2323
attr.href = chrome.extension.getURL("css/iframe.css")
2424
return attr
2525
}
26-
$("head").append($('<link>').attr(add_link(codesy.css.attr)));
27-
const endtimer = ()=> console.timeEnd('codesy append iframe');
2826
const add_src = (url, attr)=> {
2927
attr.src = `${domain}/bid-status/?${$.param({url})}`
3028
return attr
3129
}
30+
const endtimer = ()=> console.timeEnd('codesy append iframe');
31+
$link = () => $("head").append($('<link>').attr(add_link(codesy.css.attr)));
3232
$iframe = (new_url) => $('<iframe>').attr(add_src(new_url, codesy.iframe.attr))
3333
const add = (new_url) => {
3434
console.time('codesy append iframe');
35-
$('body').append($iframe(new_url)).ready(add_link).ready(endtimer)
35+
$('body').append($iframe(new_url)).ready($link).ready(endtimer)
3636
}
3737
const remove = ()=> $(`#${codesy.iframe.attr.id}`).remove();
38-
resolve( { url:'', add, remove })
38+
resolve( { url: '', add, remove })
3939
})
4040
}
4141

@@ -55,10 +55,12 @@ const watch_the_href = (widget) => {
5555
});
5656
};
5757

58+
page_reload = ()=> window.location.reload(true);
59+
5860
const get_codesy_domain = () => {
5961
return new Promise((resolve)=>{
6062
chrome.storage.local.get(null, resolve)
61-
chrome.storage.onChanged.addListener(window.location.reload)
63+
chrome.storage.onChanged.addListener(page_reload)
6264
});
6365
}
6466

0 commit comments

Comments
 (0)