fix(c11n): pagesize proof middleware lint

and clean up wip tags

Author: mydearxym

config/mock.exs

@@ -16,6 +16,6 @@ config :groupher_server, GroupherServer.Repo,
   adapter: Ecto.Adapters.Postgres,
   username: "postgres",
   password: "postgres",
-  database: "mastani_server_mock",
+  database: "groupher_server_mock",
   hostname: "localhost",
   pool_size: 10

lib/groupher_server_web/middleware/pagesize_proof.ex

@@ -23,6 +23,7 @@ defmodule GroupherServerWeb.Middleware.PageSizeProof do
       )
       when not is_nil(customization) do
     size = String.to_integer(customization.display_density)
+    size = if size > @max_page_size, do: @max_page_size, else: size
 
     case Map.has_key?(arguments, :filter) do
       true ->

lib/groupher_server_web/schema/cms/mutations/post.ex

@@ -5,7 +5,7 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Post do
   use Helper.GqlSchemaSuite
 
   object :cms_post_mutations do
-    @desc "create a user"
+    @desc "create a post"
     field :create_post, :post do
       arg(:title, non_null(:string))
       arg(:body, non_null(:string))

test/groupher_server_web/mutation/accounts/customization_test.exs

@@ -64,43 +64,33 @@ defmodule GroupherServer.Test.Mutation.Account.Customization do
     @paged_post_query """
     query($filter: PagedArticleFilter!) {
       pagedPosts(filter: $filter) {
+        entries { 
+          commentsCount
+          commentsParticipators(filter: { first: 5 }) {
+            id
+          }
+        }
         pageSize
         pageNumber
       }
     }
     """
-    test "PageSizeProof middleware should load items based on c11n settings", ~m(user)a do
+    @tag :wip
+    test "PageSizeProof middleware should lint c11n displayDensity size", ~m(user)a do
       user_conn = simu_conn(:user, user)
       db_insert_multi(:post, 50)
 
-      variables = %{filter: %{page: 1}}
-      results = user_conn |> query_result(@paged_post_query, variables, "pagedPosts")
-      assert results["pageSize"] == @max_page_size
-
       variables = %{
         customization: %{
-          displayDensity: "25"
+          displayDensity: "40"
         }
       }
 
-      user_conn |> mutation_result(@query, variables, "setCustomization")
+      hello = user_conn |> mutation_result(@query, variables, "setCustomization")
 
       variables = %{filter: %{page: 1}}
       results = user_conn |> query_result(@paged_post_query, variables, "pagedPosts")
-      assert results["pageSize"] == 25
-
-      variables = %{
-        customization: %{
-          displayDensity: "20"
-        }
-      }
-
-      user_conn |> mutation_result(@query, variables, "setCustomization")
-
-      variables = %{filter: %{page: 2}}
-      results = user_conn |> query_result(@paged_post_query, variables, "pagedPosts")
-      assert results["pageSize"] == 20
-      assert results["pageNumber"] == 2
+      assert results["pageSize"] == 30
     end
 
     test "set single customization should merge not overwright other settings", ~m(user_conn)a do

test/groupher_server_web/mutation/cms/job_test.exs

@@ -92,7 +92,6 @@ defmodule GroupherServer.Test.Mutation.Job do
       assert created["id"] == to_string(found.id)
     end
 
-    @tag :wip
     test "create job should excape xss attracts" do
       {:ok, user} = db_insert(:user)
       user_conn = simu_conn(:user, user)

test/groupher_server_web/mutation/cms/post_comment_test.exs

@@ -48,7 +48,6 @@ defmodule GroupherServer.Test.Mutation.PostComment do
       assert created["id"] == to_string(found.id)
     end
 
-    @tag :wip
     test "xss comment should be escaped", ~m(user_conn community post)a do
       variables = %{
         community: community.raw,

test/groupher_server_web/mutation/cms/repo_test.exs

@@ -154,7 +154,6 @@ defmodule GroupherServer.Test.Mutation.Repo do
       assert updated["readme"] == "new readme"
     end
 
-    @tag :wip
     test "create repo should excape xss attracts" do
       {:ok, user} = db_insert(:user)
       user_conn = simu_conn(:user, user)