chore(clean up): rm warnings & fix user views eadge case

Author: mydearxym

lib/mastani_server/accounts/delegates/customization.ex

@@ -25,7 +25,7 @@ defmodule MastaniServer.Accounts.Delegate.Customization do
     Achievements.set_member(user, :sponsor)
   end
 
-  def upgrade_by_plan(%User{} = _user, plan) do
+  def upgrade_by_plan(%User{} = _user, _plan) do
     {:error, "no such plan"}
   end
 

lib/mastani_server/billing/delegates/actions.ex

@@ -37,7 +37,7 @@ defmodule MastaniServer.Billing.Delegate.Actions do
     end
   end
 
-  def after_bill(%BillRecord{payment_usage: payment_usage} = record, _state) do
+  def after_bill(%BillRecord{payment_usage: _payment_usage}, _state) do
     {:error, "mismatch action"}
   end
 end

lib/mastani_server_web/resolvers/accounts_resolver.ex

@@ -12,10 +12,7 @@ defmodule MastaniServerWeb.Resolvers.Accounts do
 
   # def user(_root, %{id: id}, _info), do: User |> ORM.read(id, inc: :views)
   def user(_root, %{login: login}, _info), do: User |> ORM.read_by(%{login: login}, inc: :views)
-
-  def user(_root, _args, %{context: %{cur_user: cur_user}}) do
-    User |> ORM.read(cur_user.id, inc: :views)
-  end
+  def user(_root, _args, %{context: %{cur_user: cur_user}}), do: ORM.find(User, cur_user.id)
 
   def user(_root, _args, _info) do
     {:error, [message: "need login", code: ecode(:account_login)]}

lib/mastani_server_web/resolvers/billing_resolver.ex

@@ -2,11 +2,10 @@ defmodule MastaniServerWeb.Resolvers.Billing do
   @moduledoc """
   accounts resolvers
   """
-  import ShortMaps
-  import Helper.ErrorCode
+  # import ShortMaps
+  # import Helper.ErrorCode
 
-  alias Helper.{ORM, Utils}
-  alias MastaniServer.{Accounts, Billing}
+  alias MastaniServer.Billing
 
   def paged_bill_records(_root, %{filter: filter}, %{context: %{cur_user: cur_user}}) do
     Billing.list_records(cur_user, filter)
@@ -16,7 +15,7 @@ defmodule MastaniServerWeb.Resolvers.Billing do
     Billing.create_record(cur_user, args)
   end
 
-  def update_bill_state(_root, %{id: id, state: state}, %{context: %{cur_user: cur_user}}) do
+  def update_bill_state(_root, %{id: id, state: state}, %{context: %{cur_user: _cur_user}}) do
     Billing.update_record_state(id, state)
   end
 end

lib/mastani_server_web/schema/billing/billing_types.ex

@@ -1,11 +1,11 @@
 defmodule MastaniServerWeb.Schema.Billing.Types do
+  @moduledoc """
+  general types used by Billing
+  """
   use Helper.GqlSchemaSuite
 
   import MastaniServerWeb.Schema.Utils.Helper
-  import Absinthe.Resolution.Helpers
-
-  # alias MastaniServer.Billing
-  alias MastaniServerWeb.Schema
+  # import Absinthe.Resolution.Helpers
 
   enum :bill_state_enum do
     value(:pending)