chore(clean-up): rm warnings

Author: mydearxym

lib/groupher_server/accounts/delegates/fans.ex

@@ -50,7 +50,7 @@ defmodule GroupherServer.Accounts.Delegate.Fans do
     User |> ORM.find(user_follower.user_id)
   end
 
-  defp follow_result({:error, :create_follower, %Ecto.Changeset{} = result, _steps}) do
+  defp follow_result({:error, :create_follower, %Ecto.Changeset{}, _steps}) do
     {:error, [message: "already followed", code: ecode(:already_did)]}
   end
 

lib/groupher_server/cms/delegates/article_curd.ex

@@ -382,7 +382,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
 
         normal_entries = normal_contents |> Map.get(:entries)
 
-        pind_count = pined_content |> Map.get(:total_count)
+        # pind_count = pined_content |> Map.get(:total_count)
         normal_count = normal_contents |> Map.get(:total_count)
 
         # remote the pined content from normal_entries (if have)

lib/groupher_server/cms/delegates/comment_curd.ex

@@ -73,9 +73,7 @@ defmodule GroupherServer.CMS.Delegate.CommentCURD do
   @doc """
   Creates a comment for psot, job ...
   """
-  def update_comment(thread, id, %{body: body} = args, %Accounts.User{id: user_id}) do
-    {:ok, action} = match_action(thread, :comment)
-
+  def update_comment(thread, id, %{body: body}, %Accounts.User{id: user_id}) do
     with {:ok, action} <- match_action(thread, :comment),
          {:ok, content} <- ORM.find(action.reactor, id),
          true <- content.author_id == user_id do

lib/groupher_server/cms/delegates/community_operation.ex

@@ -166,7 +166,7 @@ defmodule GroupherServer.CMS.Delegate.CommunityOperation do
   def unsubscribe_community(
         %Community{id: community_id},
         %User{id: user_id, geo_city: city},
-        remote_ip
+        _remote_ip
       ) do
     with {:ok, community} <- ORM.find(Community, community_id),
          true <- community.raw !== "home",

lib/groupher_server_web/resolvers/accounts_resolver.ex

@@ -182,11 +182,11 @@ defmodule GroupherServerWeb.Resolvers.Accounts do
     Accounts.list_editable_communities(cur_user, filter)
   end
 
-  def editable_communities(_root, ~m(filter)a, %{
-        context: %{cur_user: %{cur_passport: %{"cms" => %{"root" => true}}} = _cur_user}
-      }) do
-    CMS.Community |> ORM.find_all(filter)
-  end
+  # def editable_communities(_root, ~m(filter)a, %{
+  #       context: %{cur_user: %{cur_passport: %{"cms" => %{"root" => true}}} = _cur_user}
+  #     }) do
+  #   CMS.Community |> ORM.find_all(filter)
+  # end
 
   def editable_communities(root, ~m(filter)a, _info) do
     Accounts.list_editable_communities(%User{id: root.id}, filter)
@@ -292,8 +292,7 @@ defmodule GroupherServerWeb.Resolvers.Accounts do
             _ -> %{}
           end
 
-        customization =
-          Map.merge(customization, %{sidebar_communities_index: sidebar_communities_index})
+        Map.merge(customization, %{sidebar_communities_index: sidebar_communities_index})
 
       false ->
         customization

lib/groupher_server_web/schema/cms/cms_misc.ex

@@ -263,7 +263,7 @@ defmodule GroupherServerWeb.Schema.CMS.Misc do
     field(:sort, :repo_sort_enum)
   end
 
-  @doc """
+  @desc """
   cms github repo contribotor
   """
   input_object :repo_contributor_input do
@@ -272,7 +272,7 @@ defmodule GroupherServerWeb.Schema.CMS.Misc do
     field(:nickname, :string)
   end
 
-  @doc """
+  @desc """
   cms github repo contribotor, detail version
   """
   input_object :github_contributor_input do
@@ -285,7 +285,7 @@ defmodule GroupherServerWeb.Schema.CMS.Misc do
     field(:company, :string)
   end
 
-  @doc """
+  @desc """
   cms github repo lang
   """
   input_object :repo_lang_input do

lib/helper/parse_remote_ip.ex

@@ -14,7 +14,7 @@ defmodule Helper.RemoteIP do
   def parse([proxy_ips]) do
     client_ip = proxy_ips |> String.split(",") |> List.first()
 
-    case client_ip not in slb_ips do
+    case client_ip not in slb_ips() do
       true ->
         {:ok, client_ip}
 

test/groupher_server_web/mutation/accounts/customization_test.exs

@@ -1,12 +1,6 @@
 defmodule GroupherServer.Test.Mutation.Account.Customization do
   use GroupherServer.TestTools
 
-  # alias GroupherServer.{Accounts}
-  # alias Helper.ORM
-  import Helper.Utils, only: [get_config: 2]
-
-  @max_page_size get_config(:general, :page_size)
-
   setup do
     {:ok, user} = db_insert(:user)
 
@@ -86,7 +80,7 @@ defmodule GroupherServer.Test.Mutation.Account.Customization do
         }
       }
 
-      hello = user_conn |> mutation_result(@query, variables, "setCustomization")
+      user_conn |> mutation_result(@query, variables, "setCustomization")
 
       variables = %{filter: %{page: 1}}
       results = user_conn |> query_result(@paged_post_query, variables, "pagedPosts")

test/groupher_server_web/mutation/cms/post_test.exs

@@ -63,19 +63,18 @@ defmodule GroupherServer.Test.Mutation.Post do
       assert {:ok, _} = ORM.find_by(CMS.Author, user_id: user.id)
     end
 
-    @tag :wip
     test "create post should excape xss attracts" do
       {:ok, user} = db_insert(:user)
       user_conn = simu_conn(:user, user)
 
       {:ok, community} = db_insert(:community)
-      post_attr = mock_attrs(:post, %{body: "<script>alert(\"hello,world\")</script>"})
+      post_attr = mock_attrs(:post, %{body: assert_v(:xss_string)})
 
       variables = post_attr |> Map.merge(%{communityId: community.id})
       created = user_conn |> mutation_result(@create_post_query, variables, "createPost")
       {:ok, post} = ORM.find(CMS.Post, created["id"])
 
-      assert post.body == "&lt;script&gt;alert(&quot;hello,world&quot;)&lt;/script&gt;"
+      assert post.body == assert_v(:xss_safe_string)
     end
 
     # NOTE: this test is IMPORTANT, cause json_codec: Jason in router will cause

test/support/assert_helper.ex

@@ -108,14 +108,6 @@ defmodule GroupherServer.Test.AssertHelper do
   """
   def mutation_get_error?(conn, query, variables, flag \\ false)
 
-  def mutation_get_error?(conn, query, variables, flag) do
-    conn
-    |> post("/graphiql", query: query, variables: variables)
-    |> json_response(200)
-    |> log_debug_info(flag)
-    |> Map.has_key?("errors")
-  end
-
   @doc """
   Graphiql murate error with code equal check
   """
@@ -136,6 +128,14 @@ defmodule GroupherServer.Test.AssertHelper do
     end
   end
 
+  def mutation_get_error?(conn, query, variables, flag) do
+    conn
+    |> post("/graphiql", query: query, variables: variables)
+    |> json_response(200)
+    |> log_debug_info(flag)
+    |> Map.has_key?("errors")
+  end
+
   def query_result(conn, query, variables, key, flag \\ false) do
     conn
     |> get("/graphiql", query: query, variables: variables)

test/support/factory.ex

@@ -104,14 +104,6 @@ defmodule GroupherServer.Support.Factory do
     mock_meta(:wiki)
   end
 
-  defp mock_meta(:repo_contributor) do
-    %{
-      avatar: Faker.Avatar.image_url(),
-      html_url: Faker.Avatar.image_url(),
-      nickname: "mydearxym2"
-    }
-  end
-
   defp mock_meta(:github_contributor) do
     unique_num = System.unique_integer([:positive, :monotonic])
 
@@ -256,7 +248,6 @@ defmodule GroupherServer.Support.Factory do
     %{
       avatar: Faker.Avatar.image_url(),
       html_url: Faker.Avatar.image_url(),
-      htmlUrl: Faker.Avatar.image_url(),
       nickname: "mydearxym2"
     }
   end