investigate devicemapping failures

Signed-off-by: Arjun Raja Yogidas <[email protected]>

Author: coderbirju

.github/workflows/test.yml

@@ -33,9 +33,9 @@ jobs:
           - runner: ubuntu-24.04
             containerd: v2.0.2
             arch: amd64
-          - runner: arm64-8core-32gb
-            containerd: v2.0.2
-            arch: arm64
+          # - runner: arm64-8core-32gb
+          #   containerd: v2.0.2
+          #   arch: arm64
     env:
       CONTAINERD_VERSION: "${{ matrix.containerd }}"
       ARCH: "${{ matrix.arch }}"
@@ -108,18 +108,18 @@ jobs:
             containerd: v1.6.36
             runner: "ubuntu-20.04"
             arch: amd64
-          - ubuntu: 22.04
-            containerd: v1.7.25
-            runner: "ubuntu-22.04"
-            arch: amd64
+          # - ubuntu: 22.04
+          #   containerd: v1.7.25
+          #   runner: "ubuntu-22.04"
+          #   arch: amd64
           - ubuntu: 24.04
             containerd: v2.0.2
             runner: "ubuntu-24.04"
             arch: amd64
-          - ubuntu: 24.04
-            containerd: v2.0.2
-            runner: arm64-8core-32gb
-            arch: arm64
+          # - ubuntu: 24.04
+          #   containerd: v2.0.2
+          #   runner: arm64-8core-32gb
+          #   arch: arm64
     env:
       CONTAINERD_VERSION: "${{ matrix.containerd }}"
       ARCH: "${{ matrix.arch }}"
@@ -233,21 +233,21 @@ jobs:
             rootlesskit: v1.1.1  # Deprecated
             target: rootless
             arch: amd64
-          - ubuntu: 22.04
-            containerd: v1.7.25
-            rootlesskit: v2.3.2
-            target: rootless
-            arch: amd64
-          - ubuntu: 24.04
-            containerd: v2.0.2
-            rootlesskit: v2.3.2
-            target: rootless
-            arch: amd64
-          - ubuntu: 24.04
-            containerd: v1.7.25
-            rootlesskit: v2.3.2
-            target: rootless-port-slirp4netns
-            arch: amd64
+          # - ubuntu: 22.04
+          #   containerd: v1.7.25
+          #   rootlesskit: v2.3.2
+          #   target: rootless
+          #   arch: amd64
+          # - ubuntu: 24.04
+          #   containerd: v2.0.2
+          #   rootlesskit: v2.3.2
+          #   target: rootless
+          #   arch: amd64
+          # - ubuntu: 24.04
+          #   containerd: v1.7.25
+          #   rootlesskit: v2.3.2
+          #   target: rootless-port-slirp4netns
+          #   arch: amd64
     env:
       CONTAINERD_VERSION: "${{ matrix.containerd }}"
       ARCH: "${{ matrix.arch }}"

pkg/cmd/container/create.go

@@ -118,6 +118,10 @@ func Create(ctx context.Context, client *containerd.Client, args []string, netMa
 		oci.WithDefaultSpec(),
 	)
 
+	if options.Device != nil {
+		log.L.Warnf("(TestContainerInspectDevices INFO) Calling setPlatformOptions with options.device = %v", options.Device)
+	}
+
 	platformOpts, err := setPlatformOptions(ctx, client, id, netManager.NetworkOptions().UTSNamespace, &internalLabels, options)
 	if err != nil {
 		return nil, generateRemoveStateDirFunc(ctx, id, internalLabels), err
@@ -773,6 +777,7 @@ func withInternalLabels(internalLabels internalLabels) (containerd.NewContainerO
 	}
 
 	if len(internalLabels.deviceMapping) > 0 {
+		log.L.Warn("(TestContainerInspectDevices INFO) pulling deviceMapping from internal labels ")
 		hostConfigLabel.Devices = append(hostConfigLabel.Devices, internalLabels.deviceMapping...)
 	}
 

pkg/cmd/container/run_cgroup_linux.go

@@ -201,6 +201,7 @@ func generateCgroupOpts(id string, options types.ContainerCreateOptions, interna
 		return nil, fmt.Errorf("unknown cgroupns mode %q", options.Cgroupns)
 	}
 
+	log.L.Warn("(TestContainerInspectDevices INFO) before for loop")
 	for _, f := range options.Device {
 		devPath, conPath, mode, err := ParseDevice(f)
 		if err != nil {
@@ -212,6 +213,7 @@ func generateCgroupOpts(id string, options types.ContainerCreateOptions, interna
 		deviceMap.PathInContainer = conPath
 		deviceMap.CgroupPermissions = mode
 		internalLabels.deviceMapping = append(internalLabels.deviceMapping, deviceMap)
+		log.L.Warnf("(TestContainerInspectDevices INFO) setting the device mapping info %v", deviceMap)
 	}
 
 	return opts, nil

pkg/cmd/container/run_linux.go

@@ -56,6 +56,9 @@ func setPlatformOptions(ctx context.Context, client *containerd.Client, id, uts
 			{Type: "cgroup", Source: "cgroup", Destination: "/sys/fs/cgroup", Options: []string{"ro", "nosuid", "noexec", "nodev"}},
 		}))
 
+	if options.Device != nil {
+		log.L.Warnf("(TestContainerInspectDevices INFO) Calling generateCgroupOpts with options.device = %v", options.Device)
+	}
 	cgOpts, err := generateCgroupOpts(id, options, internalLabels)
 	if err != nil {
 		return nil, err