feat: reuse agent tokens when a prebuilt agent reinitializes #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Apr 3, 2025
12 tasks
dannykopping
reviewed
Apr 7, 2025
dannykopping
approved these changes
Apr 17, 2025
| "token_provided": existingToken != "", | ||
| } | ||
| if isPrebuild && existingToken != "" { | ||
| // check if a token was already generated for this agent. |
There was a problem hiding this comment.
Nit: consistency.
Suggested change
| // check if a token was already generated for this agent. | |
| // Check if a token was already generated for this agent. |
Comment on lines
+55
to
+57
| } else { | ||
| tflog.Info(ctx, "using a new agent token", logFields) | ||
| } |
There was a problem hiding this comment.
I don't think it's necessary to log this case.
Suggested change
| } else { | |
| tflog.Info(ctx, "using a new agent token", logFields) | |
| } | |
| } |
Comment on lines
+504
to
+507
| // RunningAgentTokenEnvironmentVariable returns the name of the environment variable | ||
| // that contains the token for the running agent. This is used for prebuilds, where | ||
| // we want to reuse the same token for the next iteration of a workspace agent before | ||
| // and after the workspace was claimed by a user. |
There was a problem hiding this comment.
This comment could use some work; I think we should elaborate as to why this is being injected.
| // and after the workspace was claimed by a user. | ||
| // | ||
| // agentID is unused for now, but will be used as soon as we support multiple agents. | ||
| func RunningAgentTokenEnvironmentVariable(agentID string) string { |
There was a problem hiding this comment.
How will the ID be injected? How will we maintain a persistent identity across terraform apply runs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #364