@@ -18,14 +18,28 @@ You will need to configure `ingress` in [values.yaml](./values.yaml) to expose t
18
18
marketplace on an external domain or change ` service.type ` to get yourself an
19
19
external IP address.
20
20
21
- It is recommended to configure ` ingress ` with TLS or put the external IP behind
22
- a TLS-terminating reverse proxy because code-server will refuse to connect to
23
- the marketplace if it is not behind HTTPS .
21
+ The marketplace must be put behind TLS otherwise code-server will reject
22
+ connecting to the API. This could mean configuring ` ingress ` with TLS or putting
23
+ the external IP behind a TLS-terminating reverse proxy .
24
24
25
25
More information can be found at these links:
26
26
27
- https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types
28
- https://kubernetes.io/docs/concepts/services-networking/ingress/
27
+ - https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types
28
+ - https://kubernetes.io/docs/concepts/services-networking/ingress/
29
+
30
+ When hosting the marketplace behind a reverse proxy set either the ` Forwarded `
31
+ header or both the ` X-Forwarded-Host ` and ` X-Forwarded-Proto ` headers (the
32
+ default ` ingress ` already takes care of this). These headers are used to
33
+ generate absolute URIs to extension assets in API responses. One way to test
34
+ this is to make a query and check one of the URIs in the response:
35
+
36
+ ```
37
+ $ curl 'https://example.com/api/extensionquery' -H 'Accept: application/json;api-version=3.0-preview.1' --compressed -H 'Content-Type: application/json' --data-raw '{"filters":[{"criteria":[{"filterType":8,"value":"Microsoft.VisualStudio.Code"}],"pageSize":1}],"flags":439}' | jq .results[0].extensions[0].versions[0].assetUri
38
+ "https://example.com/assets/vscodevim/vim/1.24.1"
39
+ ```
40
+
41
+ The marketplace does not support being hosted behind a base path; it must be
42
+ proxied at the root of your domain.
29
43
30
44
## Adding/removing extensions
31
45
0 commit comments