Skip to content

Commit d3a36a9

Browse files
IrakliJaniZeRego
andauthored
feat: browserless chromium latest version from ghcr (lightdash#13386)
* feat: browserless chrome latest version from ghcr * fix: ghcr.io/browserless/chromium:v2.24.3 * fix: increase timeout + add logger * chore: by default playwright logs are debug logs --------- Co-authored-by: Jose Rego <[email protected]>
1 parent 54b26d9 commit d3a36a9

File tree

5 files changed

+29
-5
lines changed

5 files changed

+29
-5
lines changed

.github/CONTRIBUTING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ If you are running lightdash without docker, you will have to run headless brows
427427
to your lightdash endpoint in localhost. You can achive this on Linux by doing:
428428
429429
```shell
430-
docker run -e PORT=3001 --name=lightdash-headless --network 'host' -it --rm browserless/chrome
430+
docker run -e PORT=3001 --name=lightdash-headless --network 'host' -it --rm ghcr.io/browserless/chromium:v2.24.3
431431
```
432432
433433
Then make sure to configure the following ENV variables:
@@ -444,7 +444,7 @@ If you are running Lightdash without docker on Mac, you will have to run docker
444444
lightdash because it can't use localhost.
445445
446446
```shell
447-
docker run -e PORT=3001 -p 3001:3001 --name=lightdash-headless --add-host=lightdash-dev:host-gateway -it --rm browserless/chrome
447+
docker run -e PORT=3001 -p 3001:3001 --name=lightdash-headless --add-host=lightdash-dev:host-gateway -it --rm ghcr.io/browserless/chromium:v2.24.3
448448
```
449449
450450
Make sure to add the following line to your `/etc/hosts` file:

docker-compose.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ services:
5959
- db-data:/var/lib/postgresql/data
6060

6161
headless-browser:
62-
image: browserless/chrome
62+
image: ghcr.io/browserless/chromium:v2.24.3
6363
restart: always
6464
ports:
6565
- '3001:3000'

docker/Dockerfile.headless-browser

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
FROM browserless/chrome:latest
1+
FROM ghcr.io/browserless/chromium:v2.24.3

docker/docker-compose.dev.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ services:
7575
- '5432:5432'
7676

7777
headless-browser:
78-
image: browserless/chrome
78+
image: ghcr.io/browserless/chromium:v2.24.3
7979
restart: always
8080
ports:
8181
- '3001:3000'

packages/backend/src/services/UnfurlService/UnfurlService.ts

+24
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,30 @@ export class UnfurlService extends BaseService {
432432

433433
browser = await playwright.chromium.connectOverCDP(
434434
browserWSEndpoint,
435+
{
436+
timeout: 1000 * 60 * 30, // 30 minutes
437+
logger: {
438+
isEnabled() {
439+
return true;
440+
},
441+
log: (name, severity, message, args): void => {
442+
const logMessage = `[${name}] ${message} ${JSON.stringify(
443+
args,
444+
)}`;
445+
switch (severity) {
446+
case 'warning':
447+
this.logger.warn(logMessage);
448+
break;
449+
case 'error':
450+
this.logger.error(logMessage);
451+
break;
452+
default:
453+
this.logger.debug(logMessage);
454+
break;
455+
}
456+
},
457+
},
458+
},
435459
);
436460

437461
page = await browser.newPage({

0 commit comments

Comments
 (0)