remove unsafe type assertion and unused packages

improve unit tests and add useful type

Author: codenoobforreal

ffprobe.output.example.txt

@@ -0,0 +1,79 @@
+index=0
+codec_name=av1
+codec_long_name=Alliance for Open Media AV1
+profile=Main
+codec_type=video
+codec_tag_string=av01
+codec_tag=0x31307661
+width=7680
+height=4086
+coded_width=7680
+coded_height=4086
+closed_captions=0
+film_grain=0
+has_b_frames=0
+sample_aspect_ratio=N/A
+display_aspect_ratio=N/A
+pix_fmt=yuv420p
+level=16
+color_range=tv
+color_space=bt709
+color_transfer=bt709
+color_primaries=bt709
+chroma_location=unspecified
+field_order=unknown
+refs=1
+id=0x1
+r_frame_rate=25/1
+avg_frame_rate=25/1
+time_base=1/12800
+start_pts=0
+start_time=0.000000
+duration_ts=75264
+duration=5.880000
+bit_rate=31789625
+max_bit_rate=N/A
+bits_per_raw_sample=N/A
+nb_frames=147
+nb_read_frames=N/A
+nb_read_packets=N/A
+extradata_size=21
+DISPOSITION:default=1
+DISPOSITION:dub=0
+DISPOSITION:original=0
+DISPOSITION:comment=0
+DISPOSITION:lyrics=0
+DISPOSITION:karaoke=0
+DISPOSITION:forced=0
+DISPOSITION:hearing_impaired=0
+DISPOSITION:visual_impaired=0
+DISPOSITION:clean_effects=0
+DISPOSITION:attached_pic=0
+DISPOSITION:timed_thumbnails=0
+DISPOSITION:non_diegetic=0
+DISPOSITION:captions=0
+DISPOSITION:descriptions=0
+DISPOSITION:metadata=0
+DISPOSITION:dependent=0
+DISPOSITION:still_image=0
+DISPOSITION:multilayer=0
+TAG:language=und
+TAG:handler_name=ISO Media file produced by Google Inc.
+TAG:vendor_id=[0][0][0][0]
+filename=/Users/panjunyu/Downloads/process/test.mp4
+nb_streams=2
+nb_programs=0
+nb_stream_groups=0
+format_name=mov,mp4,m4a,3gp,3g2,mj2
+format_long_name=QuickTime / MOV
+start_time=0.000000
+duration=5.880000
+size=23465085
+bit_rate=31925285
+probe_score=100
+TAG:major_brand=isom
+TAG:minor_version=512
+TAG:compatible_brands=isomav01iso2mp41
+TAG:title=Magic of Hong Kong. Mind-blowing cyberpunk drone video of the craziest Asia’s city by Timelab.pro
+TAG:encoder=Lavf60.3.100
+TAG:comment=www.mediahuman.com

real-test-input/1-1/2-1/3-1/image.jpeg

@@ -0,0 +1,2 @@
+DO NOT DELETE THIS FOLDER!
+this folder is for testing purpose.

real-test-input/1-1/2-1/3-1/video.wmv

@@ -1,5 +1,5 @@
 // TODO: add ffmpeg support video ext
-export const COMMONVIDEOEXT = [
+export const SUPPORTVIDEOEXT = [
 	"avi",
 	"flv",
 	"mp4",

real-test-input/1-1/2-1/video.mp4

@@ -2,11 +2,12 @@
 
 import { select } from "@inquirer/prompts";
 
-import { defaultInputDir, defaultOutputDir } from "./path.js";
-import { compressImages } from "./tasks/compress-images.js";
-import { compressVideos } from "./tasks/compress-video.js";
+import { defaultInputDir, defaultOutputDir } from "./path";
+import { compressImages } from "./tasks/compress-images";
+import { compressVideos } from "./tasks/compress-videos";
+import type { TaskType, VideoType } from "./types";
 
-async function askToplevelTask() {
+async function askToplevelTask(): Promise<TaskType> {
 	return await select({
 		message: "Select a task",
 		choices: [
@@ -23,7 +24,7 @@ async function askToplevelTask() {
 	});
 }
 
-async function askVideoType() {
+async function askVideoType(): Promise<VideoType> {
 	return await select({
 		message: "Select video type",
 		choices: [
@@ -37,7 +38,7 @@ async function askVideoType() {
 	});
 }
 
-async function runTask(taskType: string) {
+async function runTask(taskType: TaskType) {
 	if (taskType === "compress videos") {
 		const videoType = await askVideoType();
 		await compressVideos({

real-test-input/1-1/video.flv

@@ -1,6 +1,15 @@
 import "dotenv/config";
-
+import path from "node:path";
 import process from "node:process";
 
 export const defaultInputDir = process.env["DEFAULTINPUTDIR"] as string;
 export const defaultOutputDir = process.env["DEFAULTOUTPUTDIR"] as string;
+
+export const realTestInputPath = path.join(
+	import.meta.dir,
+	"../real-test-input",
+);
+export const realTestOutputPath = path.join(
+	import.meta.dir,
+	"../real-test-output",
+);

real-test-input/1-2/2-2/image.png

@@ -0,0 +1,16 @@
+import { describe, expect, test } from "bun:test";
+
+import { realTestInputPath } from "../path";
+import { walkDir } from "./compress-images";
+
+describe("walkDir", () => {
+	test("should return exact number of dirs of the real-test folder", async () => {
+		const dirs = await walkDir([realTestInputPath]);
+		expect(dirs.length).toBeGreaterThan(0);
+		expect(dirs.length).toBe(7);
+	});
+});
+
+describe("integration test", () => {
+	test.todo("compress images without reject", async () => {}, 60 * 1000);
+});

real-test-input/1-2/2-2/video.mov

@@ -1,55 +1,42 @@
-import type { Dirent } from "node:fs";
 import fs from "node:fs";
 import fsp from "node:fs/promises";
 import path from "node:path";
 
 import sharp from "sharp";
 
-import { getAllImagesWithinDir, getFileNameFromPath } from "../utils";
+import { getAllImagesWithinPath, getFileNameFromPath } from "../utils";
 
 interface CompressImagesArgs {
 	inputDir: string;
 	outputDir: string;
 }
 
-async function dfsWalkDirFromPath(filepath: string) {
-	const dirPathes: string[] = [];
-
-	await walk(filepath);
-
-	async function walk(filepath: string) {
-		const files = await fsp.readdir(filepath, { withFileTypes: true });
-
-		for (let j = 0; j < files.length; j++) {
-			const file = files[j] as Dirent;
-			if (file.isDirectory()) {
-				await walk(path.join(file.parentPath, file.name));
-			}
-			if (j === files.length - 1) {
-				dirPathes.push(file.parentPath);
-			}
-		}
+export async function walkDir(remainingDirs: string[], accDirs: string[] = []) {
+	if (remainingDirs.length === 0) {
+		return accDirs;
 	}
-
-	return dirPathes;
+	const currentPath = remainingDirs.pop();
+	if (!currentPath) {
+		throw new Error("pop element from an empty array");
+	}
+	const files = await fsp.readdir(currentPath, { withFileTypes: true });
+	const dirs = files
+		.filter((file) => file.isDirectory())
+		.map((dir) => path.join(dir.parentPath, dir.name));
+	accDirs.push(currentPath);
+	Array.prototype.push.apply(remainingDirs, dirs);
+	return walkDir(remainingDirs, accDirs);
 }
 
 export async function compressImages(args: CompressImagesArgs) {
 	const { inputDir, outputDir } = args;
-
-	const dirs = await dfsWalkDirFromPath(inputDir);
-
-	for (let i = 0; i < dirs.length; i++) {
-		const dir = dirs[i] as string;
-
-		const images = await getAllImagesWithinDir(dir);
-
-		for (let j = 0; j < images.length; j++) {
-			const input = images[j] as string;
-
+	const dirs = await walkDir([inputDir]);
+	for (const dir of dirs) {
+		const images = await getAllImagesWithinPath(dir);
+		for (const image of images) {
 			await compressImage(
-				input,
-				path.join(outputDir, path.dirname(path.relative(inputDir, input))),
+				image,
+				path.join(outputDir, path.dirname(path.relative(inputDir, image))),
 			);
 		}
 	}