Merge pull request #65 from codefresh-io/issue_38

issue 38

Author: oren-codefresh

package.json

@@ -1,6 +1,6 @@
 {
   "name": "venona",
-  "version": "0.28.1",
+  "version": "0.28.2",
   "description": "Codefresh agent to run on Codefresh's runtime environment and execute pipeline",
   "main": "index.js",
   "scripts": {

venonactl/cmd/install.go

@@ -30,6 +30,11 @@ import (
 	"github.com/spf13/viper"
 )
 
+const (
+	clusterNameMaxLength = 20
+	namespaceMaxLength = 20
+)
+
 var installCmdOptions struct {
 	dryRun                 bool
 	clusterNameInCodefresh string
@@ -164,6 +169,11 @@ var installCmd = &cobra.Command{
 		s.CodefreshAPI.BuildNodeSelector = bns
 		builderInstallOpt.BuildNodeSelector = bns
 
+		err = validateInstallOptions(builderInstallOpt)
+		if err != nil {
+			dieOnError(err)
+		}
+
 		values := s.BuildValues()
 		for _, p := range builder.Get() {
 			values, err = p.Install(builderInstallOpt, values)
@@ -213,6 +223,16 @@ func parseNodeSelector(s string) (nodeSelector, error) {
 	return nodeSelector{v[0]: v[1]}, nil
 }
 
+func validateInstallOptions(opts* plugins.InstallOptions) (error)  {
+	if len(opts.ClusterName) > clusterNameMaxLength {
+		return errors.New(fmt.Sprintf("cluster name lenght is limited to %d", clusterNameMaxLength))
+	}
+	if len(opts.ClusterNamespace) > namespaceMaxLength {
+		return errors.New(fmt.Sprintf("cluster namespace is limited to %d", namespaceMaxLength))
+	} 	
+	return nil
+}
+
 // String returns a k8s compliant string representation of the nodeSelector. Only a single value is supported.
 func (ns nodeSelector) String() string {
 	var s string