Saas 8385 (#181)

* added --values, --set-value, --set-file to all

* added debugging from codefresh-cli

* values -tst1

* rewrite cmd-template-values

* --values for uninstall and upgrade

* debug with cli-1

* README --values

* added skip rbac

* added main_windows.go

* RuntimeInCluster

Author: kosta709

venona/VERSION

@@ -1 +1 @@
-1.4.20
+1.4.21

venonactl/VERSION

@@ -1 +1 @@
-1.4.20
+1.4.21

venonactl/cmd/attach.go

@@ -107,7 +107,9 @@ var attachRuntimeCmd = &cobra.Command{
 		}
 
 		// runtime
-		builderInstallOpt.KubeBuilder = getKubeClientBuilder(attachRuntimeCmdOptions.kube.context, attachRuntimeCmdOptions.kube.namespace, attachRuntimeCmdOptions.kube.kubePath, false)
+		var runtimeInCluster bool
+		mergeValueBool(templateValuesMap, "RuntimeInCluster", &runtimeInCluster)
+		builderInstallOpt.KubeBuilder = getKubeClientBuilder(attachRuntimeCmdOptions.kube.context, attachRuntimeCmdOptions.kube.namespace, attachRuntimeCmdOptions.kube.kubePath, runtimeInCluster)
 
 		// agent
 		builderInstallOpt.AgentKubeBuilder = getKubeClientBuilder(attachRuntimeCmdOptions.kubeVenona.context,

venonactl/cmd/cmdutils.go

@@ -294,4 +294,5 @@ func mergeValueBool(valuesMap map[string]interface{}, key string, param *bool) {
 	}
 	val := mapX.Get(key).Bool()
 	*param = val
- }
+}
+

venonactl/pkg/plugins/runtime-attach.go

@@ -57,8 +57,18 @@ func buildRuntimeConfig(opt *InstallOptions, v Values) (RuntimeConfiguration, er
 		return RuntimeConfiguration{}, fmt.Errorf("Failed to read service account runtime cluster: %v", err)
 	}
 
-	secretRef := sa.Secrets[0]
-	secret, err := cs.CoreV1().Secrets(opt.RuntimeClusterName).Get(secretRef.Name, getOpt)
+	var saSecretName string
+	saSecretPattern := fmt.Sprintf("%s-token-", opt.RuntimeServiceAccount)
+	for _, secretRef := range(sa.Secrets) {
+		if strings.Contains(secretRef.Name, saSecretPattern) {
+			saSecretName = secretRef.Name
+			break
+		}
+	}
+	if saSecretName == "" {
+		return RuntimeConfiguration{}, fmt.Errorf("Failed to get secret %s from service account %s", saSecretPattern, opt.RuntimeServiceAccount)
+	}
+	secret, err := cs.CoreV1().Secrets(opt.RuntimeClusterName).Get(saSecretName, getOpt)
 	if err != nil {
 		return RuntimeConfiguration{}, fmt.Errorf("Failed to get secret from service account on runtime cluster: %v", err)
 	}

venonactl/pkg/store/store.go

@@ -123,8 +123,10 @@ func (s *Values) BuildValues() map[string]interface{} {
 			"Key":  "",
 			"Ca":   "",
 		},
+		"CreateRbac": true,
 		"Storage": map[string]interface{}{
 			"Backend":              "local",
+			"CreateStorageClass": true,
 			"StorageClassName":     fmt.Sprintf("dind-local-volumes-%s-%s", ApplicationName, s.KubernetesAPI.Namespace),
 			"LocalVolumeParentDir": "/var/lib/codefresh/dind-volumes",
 			"AvailabilityZone":     "",
@@ -138,6 +140,7 @@ func (s *Values) BuildValues() map[string]interface{} {
 			},
 		},
 		"Monitor": map[string]interface{}{
+			"Enabled": true,
 			"UseNamespaceWithRole": s.UseNamespaceWithRole,
 			//TODO: need verify it on cluster level
 			"RbacEnabled": true,

venonactl/pkg/templates/kubernetes/cluster-role-binding.dind-volume-provisioner.vp.yaml

@@ -1,3 +1,4 @@
+{{- if .CreateRbac }}
 ---
 kind: ClusterRoleBinding
 apiVersion: rbac.authorization.k8s.io/v1beta1
@@ -13,3 +14,4 @@ roleRef:
   kind: ClusterRole
   name: volume-provisioner-{{ .AppName }}-{{ .Namespace }}
   apiGroup: rbac.authorization.k8s.io
+{{- end }}

venonactl/pkg/templates/kubernetes/cluster-role-binding.engine.yaml

@@ -1,3 +1,4 @@
+{{- if .CreateRbac }}
 kind: ClusterRoleBinding
 apiVersion: rbac.authorization.k8s.io/v1beta1
 metadata:
@@ -9,4 +10,5 @@ subjects:
 roleRef:
   kind: ClusterRole
   name: system:discovery
-  apiGroup: rbac.authorization.k8s.io
+  apiGroup: rbac.authorization.k8s.io
+{{- end }}

venonactl/pkg/templates/kubernetes/cluster-role-binding.venona.yaml

@@ -1,3 +1,4 @@
+{{- if .CreateRbac }}
 kind: ClusterRole
 apiVersion: rbac.authorization.k8s.io/v1beta1
 metadata:
@@ -29,3 +30,4 @@ rules:
   - apiGroups: [""]
     resources: ["endpoints"]
     verbs: ["get", "list", "watch", "create", "update", "delete"]
+{{- end }}