fix migrate vp (#149)

* fix migrate vp

Author: oren-codefresh

package.json

@@ -1,6 +1,6 @@
 {
   "name": "venona",
-  "version": "1.3.5",
+  "version": "1.3.6",
 
   "description": "Codefresh agent to run on Codefresh's runtime environment and execute pipeline",
   "main": "index.js",

venonactl/VERSION

@@ -1 +1 @@
-1.3.5
+1.3.6

venonactl/cmd/migrate.go

@@ -38,13 +38,16 @@ var migrateCmd = &cobra.Command{
 		lgr := createLogger("Migrate", verbose, logFormatter)
 		builder := plugins.NewBuilder(lgr)
 		builder.Add(plugins.VenonaPluginType)
+		builder.Add(plugins.RuntimeEnvironmentPluginType)
+		builder.Add(plugins.VolumeProvisionerPluginType)
 		s := store.GetStore()
 		buildBasicStore(lgr)
 		extendStoreWithKubeClient(lgr)
 		extendStoreWithCodefershClient(lgr)
 		extendStoreWithAgentAPI(lgr, "", "")
 		fillKubernetesAPI(lgr, migrateCmdOpt.kube.context, migrateCmdOpt.kube.namespace, false)
 		values := s.BuildValues()
+		values["AppName"] = "venona" // use old app name for migration
 		spn := createSpinner("Migrating runtime (might take a few seconds)", "")
 		spn.Start()
 		defer spn.Stop()

venonactl/pkg/plugins/runtime-environment.go

@@ -141,8 +141,11 @@ func (u *runtimeEnvironmentPlugin) Upgrade(_ *UpgradeOptions, v Values) (Values,
 	return v, nil
 }
 
-func (u *runtimeEnvironmentPlugin) Migrate(*MigrateOptions, Values) error {
-	return fmt.Errorf("not supported")
+func (u *runtimeEnvironmentPlugin) Migrate(opt *MigrateOptions, v Values) error {
+	return u.Delete(&DeleteOptions{
+		ClusterNamespace: opt.ClusterNamespace,
+		KubeBuilder: opt.KubeBuilder,
+	}, v)
 }
 
 func (u *runtimeEnvironmentPlugin) Test(opt TestOptions) error {

venonactl/pkg/plugins/venona.go

@@ -226,7 +226,6 @@ func (u *venonaPlugin) Migrate(opt *MigrateOptions, v Values) error {
 		u.logger.Error(fmt.Sprintf("Cannot create kubernetes clientset: %v ", err))
 		return err
 	}
-	v["AppName"] = "venona" // use old app name for migration
 	kubeObjects, err := getKubeObjectsFromTempalte(v, venonaFilesPattern, u.logger)
 	if err != nil {
 		return err

venonactl/pkg/plugins/volume-provisioner.go

@@ -108,8 +108,11 @@ func (u *volumeProvisionerPlugin) Upgrade(opt *UpgradeOptions, v Values) (Values
 	return v, nil
 
 }
-func (u *volumeProvisionerPlugin) Migrate(*MigrateOptions, Values) error {
-	return fmt.Errorf("not supported")
+func (u *volumeProvisionerPlugin) Migrate(opt *MigrateOptions, v Values) error {
+	return u.Delete(&DeleteOptions{
+		ClusterNamespace: opt.ClusterNamespace,
+		KubeBuilder: opt.KubeBuilder,
+	}, v)
 }
 
 func (u *volumeProvisionerPlugin) Test(opt TestOptions) error {