From 6ec8e3c253bf22db8f55ed2716fdef1608e479d8 Mon Sep 17 00:00:00 2001 From: Milo Fultz Date: Thu, 12 Oct 2023 18:08:05 -0700 Subject: [PATCH 1/5] Add accessible name to links --- src/components/Footer/RenderCompanyInfoSection.jsx | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/components/Footer/RenderCompanyInfoSection.jsx b/src/components/Footer/RenderCompanyInfoSection.jsx index b2c3b52e7..f9c3d13cf 100644 --- a/src/components/Footer/RenderCompanyInfoSection.jsx +++ b/src/components/Footer/RenderCompanyInfoSection.jsx @@ -23,18 +23,21 @@ const TwitterIcon = () => ( // Links for component const socialLinks = [ { + name: 'Twitter', href: 'https://twitter.com/', icon: , target: '_blank', rel: 'noopenner' }, { + name: 'Facebook', href: 'https://www.facebook.com/', icon: , target: '_blank', rel: 'noopenner' }, { + name: 'Instagram', href: 'https://www.instagram.com/', icon: , target: '_blank', @@ -60,8 +63,15 @@ const RenderCompanyInfoSection = ({ isReallySmallScreen }) => ( Follow Us - {socialLinks.map(({ href, icon }) => ( - + {socialLinks.map(({ href, icon, name }) => ( + {icon} ))} From 5afbe4b381ebccdb6436007c3b61ba2db94969d5 Mon Sep 17 00:00:00 2001 From: Milo Fultz Date: Fri, 13 Oct 2023 08:10:50 -0700 Subject: [PATCH 2/5] Add accessible name to home links --- src/components/NavBar/NavbarDesktop.jsx | 2 +- src/components/NavBar/NavbarLoggedOut.jsx | 2 +- src/components/NavBar/NavbarMobile.jsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/NavBar/NavbarDesktop.jsx b/src/components/NavBar/NavbarDesktop.jsx index 283c815e3..00a46c303 100644 --- a/src/components/NavBar/NavbarDesktop.jsx +++ b/src/components/NavBar/NavbarDesktop.jsx @@ -61,7 +61,7 @@ const NavbarDesktop = ({ setShowConfirmation }) => { - + logo ( - + logo diff --git a/src/components/NavBar/NavbarMobile.jsx b/src/components/NavBar/NavbarMobile.jsx index a1f590345..f7d39d46e 100644 --- a/src/components/NavBar/NavbarMobile.jsx +++ b/src/components/NavBar/NavbarMobile.jsx @@ -57,7 +57,7 @@ const NavbarMobile = ({ setShowConfirmation }) => { - + logo Date: Fri, 13 Oct 2023 16:09:10 -0700 Subject: [PATCH 3/5] Use aria-label over title --- src/components/Footer/RenderCompanyInfoSection.jsx | 2 +- src/components/NavBar/NavbarDesktop.jsx | 2 +- src/components/NavBar/NavbarLoggedOut.jsx | 2 +- src/components/NavBar/NavbarMobile.jsx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/Footer/RenderCompanyInfoSection.jsx b/src/components/Footer/RenderCompanyInfoSection.jsx index f9c3d13cf..379b93a21 100644 --- a/src/components/Footer/RenderCompanyInfoSection.jsx +++ b/src/components/Footer/RenderCompanyInfoSection.jsx @@ -70,7 +70,7 @@ const RenderCompanyInfoSection = ({ isReallySmallScreen }) => ( target="_blank" rel="noopener" color="#fff" - title={`Follow us on ${name}`} + aria-label={`Follow us on ${name}`} > {icon} diff --git a/src/components/NavBar/NavbarDesktop.jsx b/src/components/NavBar/NavbarDesktop.jsx index 00a46c303..71920ebcc 100644 --- a/src/components/NavBar/NavbarDesktop.jsx +++ b/src/components/NavBar/NavbarDesktop.jsx @@ -61,7 +61,7 @@ const NavbarDesktop = ({ setShowConfirmation }) => { - + logo ( - + logo diff --git a/src/components/NavBar/NavbarMobile.jsx b/src/components/NavBar/NavbarMobile.jsx index f7d39d46e..fb3f213fa 100644 --- a/src/components/NavBar/NavbarMobile.jsx +++ b/src/components/NavBar/NavbarMobile.jsx @@ -57,7 +57,7 @@ const NavbarMobile = ({ setShowConfirmation }) => { - + logo Date: Fri, 13 Oct 2023 16:12:45 -0700 Subject: [PATCH 4/5] Improve accessible name of links --- src/components/Footer/RenderCallToActionSection.jsx | 3 +-- src/pages/Home.jsx | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/components/Footer/RenderCallToActionSection.jsx b/src/components/Footer/RenderCallToActionSection.jsx index 75126a437..0baf8976d 100644 --- a/src/components/Footer/RenderCallToActionSection.jsx +++ b/src/components/Footer/RenderCallToActionSection.jsx @@ -27,14 +27,13 @@ const RenderCallToActionSection = ({ isReallySmallScreen }) => ( ); diff --git a/src/pages/Home.jsx b/src/pages/Home.jsx index b8f2fd0af..b6e169fbd 100644 --- a/src/pages/Home.jsx +++ b/src/pages/Home.jsx @@ -47,7 +47,6 @@ const Home = () => { description="Our innovative solution empowers individuals to manage their critical documents and control access for trusted organizations. PASS simplifies service access, enabling seamless documents requests and secure data sharing for a smoother support process." button="Request a Demo" href="mailto:hugh@codeforpdx.org" - label="Demo request button" /> Date: Fri, 13 Oct 2023 16:20:50 -0700 Subject: [PATCH 5/5] Update snapshot --- test/pages/__snapshots__/Home.test.jsx.snap | 1 - 1 file changed, 1 deletion(-) diff --git a/test/pages/__snapshots__/Home.test.jsx.snap b/test/pages/__snapshots__/Home.test.jsx.snap index c62dc46bb..cae4f6f44 100644 --- a/test/pages/__snapshots__/Home.test.jsx.snap +++ b/test/pages/__snapshots__/Home.test.jsx.snap @@ -32,7 +32,6 @@ exports[`Home Page > renders 1`] = ` Our innovative solution empowers individuals to manage their critical documents and control access for trusted organizations. PASS simplifies service access, enabling seamless documents requests and secure data sharing for a smoother support process.