Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max height for autocomplete and signInModal components #541

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add max height for autocomplete and signInModal components #541

merged 1 commit into from
Nov 27, 2023

Conversation

rioredwards
Copy link
Contributor

This PR:

Resolves #539

Screenshots (if applicable):

Pass-Screen-Recording.mov

Additional Context (optional):

The issue this PR resolves is actually asking to add vertical scrolling functionality to the Autocomplete. However, adding a max height to the component addresses the issue... The Autocomplete component had scrollable functionality all along, so by limiting its height, this allows the component's content to be scrollable.

@leekahung leekahung added the enhancement Enhancement of existing features label Nov 25, 2023
@leekahung
Copy link
Contributor

As stated from Issue #539:

Still think it'll be better if we could keep the modal from changing and allow the autocomplete vertical scroll

Is it possible to just have the drop down without the modal changing?

leekahung
leekahung requested changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@leekahung leekahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See earlier comment about modal.

@rioredwards
Copy link
Contributor Author

Is it possible to just have the drop down without the modal changing?

I think this must be possible, but I couldn't figure out how to do it...

I tried just limiting the height of the Autocomplete component, but the parent component was still resizing as if the Autocomplete's height wasn't being limited... From what I could find, MUI doesn't provide an intuitive way to limit the height of this component, so this was the best I could come up with.

I'm still getting the hang of MUI, but if anyone here wants to dig in and find a better solution, I would be happy to see it done right!

@leekahung
Copy link
Contributor

I think this must be possible, but I couldn't figure out how to do it...

I tried just limiting the height of the Autocomplete component, but the parent component was still resizing as if the Autocomplete's height wasn't being limited... From what I could find, MUI doesn't provide an intuitive way to limit the height of this component, so this was the best I could come up with.

I'm still getting the hang of MUI, but if anyone here wants to dig in and find a better solution, I would be happy to see it done right!

No worries @rioredwards , all good! Had poked around a bit locally too without much luck. Think we could just approve this for now as a tentative solution.

@leekahung leekahung self-requested a review November 27, 2023 12:51
@rioredwards rioredwards merged commit 5dfdc94 into Development Nov 27, 2023
3 checks passed
@andycwilliams andycwilliams deleted the 539-Enhancement-Add-Max-Height-For-Sign-In-Autocomplete-Component branch December 20, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbot1789 timbot1789 timbot1789 approved these changes

@leekahung leekahung leekahung approved these changes

Assignees

@rioredwards rioredwards

Labels
enhancement Enhancement of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] - Vertical scrolling for sign in autocomplete
3 participants
@rioredwards @leekahung @timbot1789