Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 524/update profile to account #560

Closed
wants to merge 18 commits into from

Conversation

xscottxbrownx
Copy link
Contributor

@xscottxbrownx xscottxbrownx commented Dec 9, 2023

This PR:

Resolves #524

1. Changes profile route path & file/function/variable names to account
2. Changes civic-profile route path & file/function/variable names to profile

Screenshots (if applicable):

Screen.Recording.2023-12-09.at.12.35.07.PM.mov

Issues needing discussion/feedback (optional):

1. If we also want to change the internal solid files or folders to match (.ttl)
2. Changes needed to useCivicProfile hook?
3. Changes needed to src > model-helpers > Profile.js code around line 130 'civic access'?
4. Changes needed to localStorage.setItem('profileImage') ? Couldn't tell where 'profileImage' was first stored/created and if it could be changed to 'accountImage'

@xscottxbrownx xscottxbrownx added the enhancement Enhancement of existing features label Dec 9, 2023
@xscottxbrownx xscottxbrownx self-assigned this Dec 9, 2023
@leekahung
Copy link
Contributor

  1. Changes needed to localStorage.setItem('profileImage') ? Couldn't tell where 'profileImage' was first stored/created and if it could be changed to 'accountImage'

The initial point where profileImage is first stored is SignedInUserContext

Copy link
Contributor

@timbot1789 timbot1789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we actually want to change the name of the civic profile to this. IMO it makes the UI more confusing.

This is an object that contains specific, sensitive information that should only be shared with certain people. We need a name that communicates that to users. The purpose of the adjective "civic" in "civic profile" is to communicate this. "Profile" is vague, and not actually all that distinct from an "account."


"Account" itself is also a weird name because that data isn't associated with an account. An account is an entry about you opened in the books at some organization. That's not what happening here. You're instead modifying data on an ID card that has been issued to you.

@xscottxbrownx
Copy link
Contributor Author

I don't think we actually want to change the name of the civic profile to this. IMO it makes the UI more confusing.

This is an object that contains specific, sensitive information that should only be shared with certain people. We need a name that communicates that to users. The purpose of the adjective "civic" in "civic profile" is to communicate this. "Profile" is vague, and not actually all that distinct from an "account."

"Account" itself is also a weird name because that data isn't associated with an account. An account is an entry about you opened in the books at some organization. That's not what happening here. You're instead modifying data on an ID card that has been issued to you.


Fair.

  1. Maybe we should have some sort of workflow for Issues, then. So people don't spend hours on things that haven't been agreed upon.

  2. Do you have any suggestions for naming then?

  3. I probably just don't understand the whole concept of why we have a 'civic profile' and a 'profile', as I've missed a lot of dev meetings. But if it's just some data is private and some is public, why not just have a single profile with two sections - the public section and the private section?

@timbot1789
Copy link
Contributor

@xscottxbrownx Let's move this discussion over to the issue.

@timbot1789
Copy link
Contributor

timbot1789 commented Mar 3, 2024

@xscottxbrownx Are you opposed to closing this? I don't think we'll be acting on this PR as is. I think we need to talk more about the fundamental design. We can reopen this once we get the design more hashed out.

@xscottxbrownx
Copy link
Contributor Author

Continuing discussion before implementing any changes - closing PR for now.

@xscottxbrownx xscottxbrownx deleted the issue-524/update-profile-to-account branch March 3, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] - Update naming for Civic Profile and/or Profile
3 participants