-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 524/update profile to account #560
Conversation
The initial point where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we actually want to change the name of the civic profile to this. IMO it makes the UI more confusing.
This is an object that contains specific, sensitive information that should only be shared with certain people. We need a name that communicates that to users. The purpose of the adjective "civic" in "civic profile" is to communicate this. "Profile" is vague, and not actually all that distinct from an "account."
"Account" itself is also a weird name because that data isn't associated with an account. An account is an entry about you opened in the books at some organization. That's not what happening here. You're instead modifying data on an ID card that has been issued to you.
Fair.
|
@xscottxbrownx Let's move this discussion over to the issue. |
@xscottxbrownx Are you opposed to closing this? I don't think we'll be acting on this PR as is. I think we need to talk more about the fundamental design. We can reopen this once we get the design more hashed out. |
Continuing discussion before implementing any changes - closing PR for now. |
This PR:
Resolves #524
1. Changes
profile
route path & file/function/variable names toaccount
2. Changes
civic-profile
route path & file/function/variable names toprofile
Screenshots (if applicable):
Screen.Recording.2023-12-09.at.12.35.07.PM.mov
Issues needing discussion/feedback (optional):
1. If we also want to change the internal solid files or folders to match (.ttl)
2. Changes needed to
useCivicProfile
hook?3. Changes needed to
src
>model-helpers
>Profile.js
code around line 130 'civic access'?4. Changes needed to
localStorage.setItem('profileImage')
? Couldn't tell where 'profileImage' was first stored/created and if it could be changed to 'accountImage'