Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentTableRow window.confirm to MUI modal #316

Closed
leekahung opened this issue Jul 18, 2023 · 1 comment · Fixed by #428
Closed

DocumentTableRow window.confirm to MUI modal #316

leekahung opened this issue Jul 18, 2023 · 1 comment · Fixed by #428
Assignees
@xscottxbrownx
Labels
enhancement Enhancement of existing features

Comments

@leekahung
Copy link
Contributor

leekahung commented Jul 18, 2023 •
edited by xscottxbrownx
Loading

Is your feature request related to a problem? Please describe.
Current component for DocumentTableRow uses window.confirm to alert users of deleting document. This could be updated to use a modal.

Describe the solution you'd like
NEW DIRECTION:
create a ConfirmationModal that can be used any place we just need a "are you sure you want to do this?" notification with a "cancel" and "confirm" button.

This ConfirmationModal should be able to replace:
LogoutModal
DeleteContactModal
DeleteDocumentModal <-- first attempt at solving this Issue.
@leekahung leekahung added the enhancement Enhancement of existing features label Jul 18, 2023
@xscottxbrownx xscottxbrownx self-assigned this Aug 11, 2023
@xscottxbrownx xscottxbrownx mentioned this issue Aug 15, 2023
Closed
@xscottxbrownx xscottxbrownx linked a pull request Aug 15, 2023 that will close this issue
Issue 316/delete document modal #381
Closed
@xscottxbrownx
Copy link
Contributor

Little stalled while waiting for PR #392 + PR #388 to be finished up. But most of code is there and just waiting for these to be complete so I can complete this one.

@xscottxbrownx xscottxbrownx mentioned this issue Sep 15, 2023
Merged
@xscottxbrownx xscottxbrownx removed a link to a pull request Sep 15, 2023
Issue 316/delete document modal #381
Closed
@xscottxbrownx xscottxbrownx linked a pull request Sep 15, 2023 that will close this issue
Create confirmation modal #428
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xscottxbrownx xscottxbrownx

Labels
enhancement Enhancement of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create confirmation modal codeforpdx/PASS
2 participants
@leekahung @xscottxbrownx