-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the alert popup on delete of client a MUI modal component (ClientListTableRow.jsx) #223
Comments
@xscottxbrownx I am interested in this, can you assign this to me? |
Have you read this repo's readme's on contributing and such? When creating new branch from |
@xscottxbrownx I have a made delete client modal and it works fine, I have attached a screenshot of it, could you review it, please? |
Well, all I can do right now is see what it looks like from your screenshot. Can you make a pull request, so I can test on local machine and look at the code? And in the future, could you make sure you get assigned to the issue before proceeding? If an issue isn't assigned, other developers will think it's free to be worked on and it will lead to somebody wasting their time or merge conflicts. |
As a beginner to open source, I didn't know about it, but in the future, I will take care of it, thank you @xscottxbrownx for helping me. |
Now i made a pull request with the title Created DeleteClientModal, could you review, please |
Thank you. Also just another thing to help with GitHub use... you can link to an Issue or PR by using it's number. So in this case you could add #257 and it would provide a link to the PR you created. As soon as you type the |
We may want to reassign this to @xscottxbrownx since he is now taking over responsibility. |
Assignment switched to @xscottxbrownx |
Issue:
When clicking the
delete
icon in the table of clients, an alert message pops up to confirm. Need to use an MUI modal and styling to match rest of app instead.Direction:
Take inspiration from our other MUI modals to have similar styling for this.
LogoutModal
,AddClientModal
(which isn't 100% complete yet), and evenInactivityMessage
are all closely styled and fit within the app theme.The text was updated successfully, but these errors were encountered: