Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the alert popup on delete of client a MUI modal component (ClientListTableRow.jsx) #223

Closed
xscottxbrownx opened this issue Jun 6, 2023 · 9 comments · Fixed by #287
Assignees
Labels
enhancement Enhancement of existing features

Comments

@xscottxbrownx
Copy link
Contributor

Issue:

When clicking the delete icon in the table of clients, an alert message pops up to confirm. Need to use an MUI modal and styling to match rest of app instead.


Direction:

Take inspiration from our other MUI modals to have similar styling for this.
LogoutModal, AddClientModal (which isn't 100% complete yet), and even InactivityMessage are all closely styled and fit within the app theme.

Screenshot 2023-06-06 at 2 58 12 PM
@xscottxbrownx xscottxbrownx added the enhancement Enhancement of existing features label Jun 6, 2023
@ajay2827
Copy link

@xscottxbrownx I am interested in this, can you assign this to me?

@xscottxbrownx
Copy link
Contributor Author

@xscottxbrownx I am interested in this, can you assign this to me?

Have you read this repo's readme's on contributing and such?

When creating new branch from Development for this, make sure to start branch name with issue-223/ followed by whatever you want to call branch (something like: "delete-client-modal")

@ajay2827
Copy link

@xscottxbrownx I have a made delete client modal and it works fine, I have attached a screenshot of it, could you review it, please?
Screenshot 2023-06-16 150741

@xscottxbrownx
Copy link
Contributor Author

xscottxbrownx commented Jun 16, 2023

@xscottxbrownx I have a made delete client modal and it works fine, I have attached a screenshot of it, could you review it, please?

Well, all I can do right now is see what it looks like from your screenshot.

Can you make a pull request, so I can test on local machine and look at the code?


And in the future, could you make sure you get assigned to the issue before proceeding?
You didn't get assigned because you never responded to my questions.

If an issue isn't assigned, other developers will think it's free to be worked on and it will lead to somebody wasting their time or merge conflicts.

@ajay2827
Copy link

@xscottxbrownx I have a made delete client modal and it works fine, I have attached a screenshot of it, could you review it, please?

Well, all I can do right now is see what it looks like from your screenshot.

Can you make a pull request, so I can test on local machine and look at the code?

And in the future, could you make sure you get assigned to the issue before proceeding? You didn't get assigned because you never responded to my questions.

If an issue isn't assigned, other developers will think it's free to be worked on and it will lead to somebody wasting their time or merge conflicts.

As a beginner to open source, I didn't know about it, but in the future, I will take care of it, thank you @xscottxbrownx for helping me.

@ajay2827
Copy link

@xscottxbrownx I have a made delete client modal and it works fine, I have attached a screenshot of it, could you review it, please?

Well, all I can do right now is see what it looks like from your screenshot.

Can you make a pull request, so I can test on local machine and look at the code?

And in the future, could you make sure you get assigned to the issue before proceeding? You didn't get assigned because you never responded to my questions.

If an issue isn't assigned, other developers will think it's free to be worked on and it will lead to somebody wasting their time or merge conflicts.

Now i made a pull request with the title Created DeleteClientModal, could you review, please

@xscottxbrownx xscottxbrownx linked a pull request Jun 16, 2023 that will close this issue
@xscottxbrownx
Copy link
Contributor Author

Now i made a pull request with the title Created DeleteClientModal, could you review, please

Thank you.

Also just another thing to help with GitHub use... you can link to an Issue or PR by using it's number.

So in this case you could add #257 and it would provide a link to the PR you created. As soon as you type the # symbol it should popup a list for you to select from. Just another tip.

@andycwilliams
Copy link
Member

We may want to reassign this to @xscottxbrownx since he is now taking over responsibility.

@andycwilliams andycwilliams linked a pull request Jul 2, 2023 that will close this issue
@leekahung leekahung assigned xscottxbrownx and unassigned ajay2827 Jul 3, 2023
@leekahung
Copy link
Contributor

Assignment switched to @xscottxbrownx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing features
Projects
None yet
4 participants